Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-06 Thread Daniel Vetter
On Fri, Feb 03, 2017 at 12:25:24PM +, Emil Velikov wrote: > On 3 February 2017 at 08:00, Daniel Vetter wrote: > > On Thu, Feb 02, 2017 at 12:37:21PM +, Emil Velikov wrote: > >> - Daniel, gents - is drm-misc aimed at devs with limited (no?) > >> review/commit history in the area and/or the

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-03 Thread Emil Velikov
On 3 February 2017 at 08:00, Daniel Vetter wrote: > On Thu, Feb 02, 2017 at 12:37:21PM +, Emil Velikov wrote: >> - Daniel, gents - is drm-misc aimed at devs with limited (no?) >> review/commit history in the area and/or the kernel in general ? >> In this case, Peter have quite noticeable expe

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-03 Thread Daniel Vetter
On Thu, Feb 02, 2017 at 12:37:21PM +, Emil Velikov wrote: > - Daniel, gents - is drm-misc aimed at devs with limited (no?) > review/commit history in the area and/or the kernel in general ? > In this case, Peter have quite noticeable experience [in kernel > development] with little-to no in DR

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-02 Thread Emil Velikov
On 2 February 2017 at 11:53, Peter Senna Tschudin wrote: > > On 02 February, 2017 02:46 CET, Emil Velikov wrote: > >> On 1 February 2017 at 11:35, Daniel Vetter wrote: >> > On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: >> >> Hi Archit, >> >> >> >> On 01 February, 2017 10:

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-02 Thread Peter Senna Tschudin
On 02 February, 2017 02:46 CET, Emil Velikov wrote: > On 1 February 2017 at 11:35, Daniel Vetter wrote: > > On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: > >> Hi Archit, > >> > >> On 01 February, 2017 10:44 CET, Archit Taneja > >> wrote: > >> > >> > > >> > > >> > On

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-02 Thread Archit Taneja
On 02/01/2017 05:51 PM, Peter Senna Tschudin wrote: On 01 February, 2017 12:35 CET, Daniel Vetter wrote: On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: Hi Archit, On 01 February, 2017 10:44 CET, Archit Taneja wrote: On 01/30/2017 10:35 PM, Jani Nikula wrote: O

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-01 Thread Emil Velikov
On 1 February 2017 at 11:35, Daniel Vetter wrote: > On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: >> Hi Archit, >> >> On 01 February, 2017 10:44 CET, Archit Taneja wrote: >> >> > >> > >> > On 01/30/2017 10:35 PM, Jani Nikula wrote: >> > > On Sat, 28 Jan 2017, Peter Senna T

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-01 Thread Peter Senna Tschudin
On 01 February, 2017 12:35 CET, Daniel Vetter wrote: > On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: > > Hi Archit, > > > > On 01 February, 2017 10:44 CET, Archit Taneja > > wrote: > > > > > > > > > > > On 01/30/2017 10:35 PM, Jani Nikula wrote: > > > > On Sat, 28

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-01 Thread Daniel Vetter
On Wed, Feb 01, 2017 at 10:58:43AM +, Peter Senna Tschudin wrote: > Hi Archit, > > On 01 February, 2017 10:44 CET, Archit Taneja wrote: > > > > > > > On 01/30/2017 10:35 PM, Jani Nikula wrote: > > > On Sat, 28 Jan 2017, Peter Senna Tschudin > > > wrote: > > >> On Thu, Jan 05, 2017 at 01:18

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-01 Thread Peter Senna Tschudin
Hi Archit, On 01 February, 2017 10:44 CET, Archit Taneja wrote: > > > On 01/30/2017 10:35 PM, Jani Nikula wrote: > > On Sat, 28 Jan 2017, Peter Senna Tschudin wrote: > >> On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: > >> Hi Archit, > >> > >> Thank you for the comments! > >

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-02-01 Thread Archit Taneja
On 01/30/2017 10:35 PM, Jani Nikula wrote: On Sat, 28 Jan 2017, Peter Senna Tschudin wrote: On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: Hi Archit, Thank you for the comments! [...] + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH; + if (total_size

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-01-30 Thread Jani Nikula
On Sat, 28 Jan 2017, Peter Senna Tschudin wrote: > On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: > Hi Archit, > > Thank you for the comments! > > [...] >> > + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH; >> > + if (total_size > EDID_LENGTH) { >> > + kfree

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-01-28 Thread Peter Senna Tschudin
On Thu, Jan 05, 2017 at 01:18:47PM +0530, Archit Taneja wrote: Hi Archit, Thank you for the comments! [...] > > + total_size = (block[EDID_EXT_BLOCK_CNT] + 1) * EDID_LENGTH; > > + if (total_size > EDID_LENGTH) { > > + kfree(block); > > + block = kmalloc(total_size, GFP_KER

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-01-04 Thread Archit Taneja
Hi, Some comments below. On 01/02/2017 01:54 AM, Peter Senna Tschudin wrote: Add a driver that create a drm_bridge and a drm_connector for the LVDS to DP++ display bridge of the GE B850v3. There are two physical bridges on the video signal pipeline: a STDP4028(LVDS to DP) and a STDP2690(DP to

Re: [PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-01-02 Thread Peter Senna Tschudin
On 01 January, 2017 21:24 CET, Peter Senna Tschudin wrote: [ ... ] > +static void ge_b850v3_lvds_dp_detach(struct drm_bridge *bridge) > +{ > + struct ge_b850v3_lvds_dp *ptn_bridge > + = bridge_to_ge_b850v3_lvds_dp(bridge); > + struct i2c_client *ge_b850v3_lvds_dp

[PATCH V7 3/4] drm/bridge: Add driver for GE B850v3 LVDS/DP++ Bridge

2017-01-01 Thread Peter Senna Tschudin
Add a driver that create a drm_bridge and a drm_connector for the LVDS to DP++ display bridge of the GE B850v3. There are two physical bridges on the video signal pipeline: a STDP4028(LVDS to DP) and a STDP2690(DP to DP++). The hardware and firmware made it complicated for this binding to compris