Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-10-13 Thread Qais Yousef
On 10/13/20 12:43, Frederic Weisbecker wrote: > On Fri, Oct 09, 2020 at 04:01:39PM +0100, Qais Yousef wrote: > > On 09/29/20 13:44, Frederic Weisbecker wrote: > > > > that will delay the net_rx/tx softirq to process, Peter's branch > > > > maybe can slove > > > > the problem > > > >

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-10-13 Thread Frederic Weisbecker
On Fri, Oct 09, 2020 at 04:01:39PM +0100, Qais Yousef wrote: > On 09/29/20 13:44, Frederic Weisbecker wrote: > > > that will delay the net_rx/tx softirq to process, Peter's branch > > > maybe can slove > > > the problem > > > git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git > > >

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-10-09 Thread Qais Yousef
On 09/29/20 13:44, Frederic Weisbecker wrote: > > that will delay the net_rx/tx softirq to process, Peter's branch > > maybe can slove > > the problem > > git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git core/softirq > > It's probably also the right time for me to resume on this

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-29 Thread Frederic Weisbecker
On Mon, Sep 28, 2020 at 06:51:48PM +0800, jun qian wrote: > Frederic Weisbecker 于2020年9月25日周五 上午8:42写道： > > > > On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: > > > Subject: softirq; Prevent starvation of higher softirq vectors > > [...] > > > + /* > > > + * Word swap

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-28 Thread jun qian
Peter Zijlstra 于2020年9月28日周一 下午5:20写道： > > On Tue, Sep 15, 2020 at 07:56:09PM +0800, qianjun.ker...@gmail.com wrote: > > From: jun qian > > > > Allow terminating the softirq processing loop without finishing the vectors. > > > > Signed-off-by: jun qian > > --- > > kernel/softirq.c | 113 > >

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-28 Thread jun qian
Frederic Weisbecker 于2020年9月25日周五 上午8:42写道： > > On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: > > Subject: softirq; Prevent starvation of higher softirq vectors > [...] > > + /* > > + * Word swap pending to move the not yet handled bits of the previous > > + * run

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-28 Thread Thomas Gleixner
On Mon, Sep 28 2020 at 11:22, Peter Zijlstra wrote: > On Tue, Sep 15, 2020 at 07:56:09PM +0800, qianjun.ker...@gmail.com wrote: >> +/* >> + * The pending_next_bit is recorded for the next processing order when >> + * the loop is broken. This per cpu variable is to solve the following >> + *

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-28 Thread Peter Zijlstra
On Tue, Sep 15, 2020 at 07:56:09PM +0800, qianjun.ker...@gmail.com wrote: > +/* > + * The pending_next_bit is recorded for the next processing order when > + * the loop is broken. This per cpu variable is to solve the following > + * scenarios: This, that adds all that complexity, and I think

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-28 Thread Peter Zijlstra
On Tue, Sep 15, 2020 at 07:56:09PM +0800, qianjun.ker...@gmail.com wrote: > From: jun qian > > Allow terminating the softirq processing loop without finishing the vectors. > > Signed-off-by: jun qian > --- > kernel/softirq.c | 113 > --- >

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-26 Thread Frederic Weisbecker
On Sat, Sep 26, 2020 at 12:42:25AM +0200, Thomas Gleixner wrote: > On Fri, Sep 25 2020 at 02:42, Frederic Weisbecker wrote: > > > On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: > >> Subject: softirq; Prevent starvation of higher softirq vectors > > [...] > >> + /* > >> + *

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-25 Thread jun qian
Thomas Gleixner 于2020年9月24日周四 下午11:37写道： > > On Tue, Sep 15 2020 at 19:56, qianjun kernel wrote: > > > > +#define SOFTIRQ_PENDING_MASK ((1UL << NR_SOFTIRQS) - 1) > > > > +/* > > + * The pending_next_bit is recorded for the next processing order when > > + * the loop is broken. This per cpu

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-25 Thread Thomas Gleixner
On Fri, Sep 25 2020 at 02:42, Frederic Weisbecker wrote: > On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: >> Subject: softirq; Prevent starvation of higher softirq vectors > [...] >> +/* >> + * Word swap pending to move the not yet handled bits of the previous >> + *

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-25 Thread Thomas Gleixner
On Fri, Sep 25 2020 at 01:08, Frederic Weisbecker wrote: > On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: >> Subject: softirq; Prevent starvation of higher softirq vectors >> From: Thomas Gleixner >> Date: Thu, 24 Sep 2020 10:40:24 +0200 >> >> From: Thomas Gleixner >> >> The

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-24 Thread Frederic Weisbecker
On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: > Subject: softirq; Prevent starvation of higher softirq vectors [...] > + /* > + * Word swap pending to move the not yet handled bits of the previous > + * run first and then clear the duplicates in the newly raised

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-24 Thread Frederic Weisbecker
On Fri, Sep 25, 2020 at 01:08:11AM +0200, Frederic Weisbecker wrote: > On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: > > Subject: softirq; Prevent starvation of higher softirq vectors > > From: Thomas Gleixner > > Date: Thu, 24 Sep 2020 10:40:24 +0200 > > > > From: Thomas

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-24 Thread Frederic Weisbecker
On Thu, Sep 24, 2020 at 05:37:42PM +0200, Thomas Gleixner wrote: > Subject: softirq; Prevent starvation of higher softirq vectors > From: Thomas Gleixner > Date: Thu, 24 Sep 2020 10:40:24 +0200 > > From: Thomas Gleixner > > The early termination of the softirq processing loop can lead to

Re: [PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-24 Thread Thomas Gleixner
On Tue, Sep 15 2020 at 19:56, qianjun kernel wrote: > > +#define SOFTIRQ_PENDING_MASK ((1UL << NR_SOFTIRQS) - 1) > > +/* > + * The pending_next_bit is recorded for the next processing order when > + * the loop is broken. This per cpu variable is to solve the following > + * scenarios: > + *

[PATCH V7 4/4] softirq: Allow early break the softirq processing loop

2020-09-15 Thread qianjun . kernel
From: jun qian Allow terminating the softirq processing loop without finishing the vectors. Signed-off-by: jun qian --- kernel/softirq.c | 113 --- 1 file changed, 91 insertions(+), 22 deletions(-) diff --git a/kernel/softirq.c