Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-10-08 Thread Anshuman Khandual
On 10/08/2019 04:25 PM, Catalin Marinas wrote: > On Tue, Oct 08, 2019 at 10:06:26AM +0530, Anshuman Khandual wrote: >> On 10/07/2019 07:47 PM, Catalin Marinas wrote: >>> On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote: The arch code for hot-remove must tear down portions

Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-10-08 Thread Catalin Marinas
On Tue, Oct 08, 2019 at 10:06:26AM +0530, Anshuman Khandual wrote: > On 10/07/2019 07:47 PM, Catalin Marinas wrote: > > On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote: > >> The arch code for hot-remove must tear down portions of the linear map and > >> vmemmap corresponding to

Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-10-07 Thread Anshuman Khandual
On 10/07/2019 07:47 PM, Catalin Marinas wrote: > On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote: >> The arch code for hot-remove must tear down portions of the linear map and >> vmemmap corresponding to memory being removed. In both cases the page >> tables mapping these

Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-10-07 Thread Catalin Marinas
On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote: > The arch code for hot-remove must tear down portions of the linear map and > vmemmap corresponding to memory being removed. In both cases the page > tables mapping these regions must be freed, and when sparse vmemmap is in > use

Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-09-24 Thread Anshuman Khandual
On 09/23/2019 04:47 PM, Matthew Wilcox wrote: > On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote: >> +#ifdef CONFIG_MEMORY_HOTPLUG >> +static void free_hotplug_page_range(struct page *page, size_t size) >> +{ >> +WARN_ON(!page || PageReserved(page)); > > WARN_ON(!page)

Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-09-23 Thread kbuild test robot
Hi Anshuman, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3 next-20190920] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to

Re: [PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-09-23 Thread Matthew Wilcox
On Mon, Sep 23, 2019 at 11:13:45AM +0530, Anshuman Khandual wrote: > +#ifdef CONFIG_MEMORY_HOTPLUG > +static void free_hotplug_page_range(struct page *page, size_t size) > +{ > + WARN_ON(!page || PageReserved(page)); WARN_ON(!page) isn't terribly useful. You're going to crash on the very

[PATCH V8 2/2] arm64/mm: Enable memory hot remove

2019-09-22 Thread Anshuman Khandual
The arch code for hot-remove must tear down portions of the linear map and vmemmap corresponding to memory being removed. In both cases the page tables mapping these regions must be freed, and when sparse vmemmap is in use the memory backing the vmemmap must also be freed. This patch adds