Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-21 Thread Guo Ren
Thx Peter, Your review has been a great help. On Sun, Oct 21, 2018 at 10:55:08PM +0200, Peter Zijlstra wrote: > On Tue, Oct 16, 2018 at 10:58:30AM +0800, Guo Ren wrote: > > + smp_mb(); > > + lock->tickets.owner++; > > WRITE_ONCE(lock->tickets.owner, lock->tickets.owner + 1); Yes,

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-21 Thread Guo Ren
Thx Peter, Your review has been a great help. On Sun, Oct 21, 2018 at 10:55:08PM +0200, Peter Zijlstra wrote: > On Tue, Oct 16, 2018 at 10:58:30AM +0800, Guo Ren wrote: > > + smp_mb(); > > + lock->tickets.owner++; > > WRITE_ONCE(lock->tickets.owner, lock->tickets.owner + 1); Yes,

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-21 Thread Peter Zijlstra
On Tue, Oct 16, 2018 at 10:58:30AM +0800, Guo Ren wrote: > diff --git a/arch/csky/include/asm/spinlock.h > b/arch/csky/include/asm/spinlock.h > new file mode 100644 > index 000..0474603 > --- /dev/null > +++ b/arch/csky/include/asm/spinlock.h > @@ -0,0 +1,274 @@ > +/*

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-21 Thread Peter Zijlstra
On Tue, Oct 16, 2018 at 10:58:30AM +0800, Guo Ren wrote: > diff --git a/arch/csky/include/asm/spinlock.h > b/arch/csky/include/asm/spinlock.h > new file mode 100644 > index 000..0474603 > --- /dev/null > +++ b/arch/csky/include/asm/spinlock.h > @@ -0,0 +1,274 @@ > +/*

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-17 Thread Guo Ren
On Wed, Oct 17, 2018 at 05:17:05PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:02 AM Guo Ren wrote: > > > > This patch adds atomic, cmpxchg, spinlock files. > > > > Signed-off-by: Guo Ren > > Cc: Peter Zijlstra > > Cc: Andrea Parri > > Cc: Arnd Bergmann > > I'd wait for Peter to

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-17 Thread Guo Ren
On Wed, Oct 17, 2018 at 05:17:05PM +0200, Arnd Bergmann wrote: > On Tue, Oct 16, 2018 at 5:02 AM Guo Ren wrote: > > > > This patch adds atomic, cmpxchg, spinlock files. > > > > Signed-off-by: Guo Ren > > Cc: Peter Zijlstra > > Cc: Andrea Parri > > Cc: Arnd Bergmann > > I'd wait for Peter to

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-17 Thread Arnd Bergmann
On Tue, Oct 16, 2018 at 5:02 AM Guo Ren wrote: > > This patch adds atomic, cmpxchg, spinlock files. > > Signed-off-by: Guo Ren > Cc: Peter Zijlstra > Cc: Andrea Parri > Cc: Arnd Bergmann I'd wait for Peter to give his final Ack here. Arnd

Re: [PATCH V9 11/21] csky: Atomic operations

2018-10-17 Thread Arnd Bergmann
On Tue, Oct 16, 2018 at 5:02 AM Guo Ren wrote: > > This patch adds atomic, cmpxchg, spinlock files. > > Signed-off-by: Guo Ren > Cc: Peter Zijlstra > Cc: Andrea Parri > Cc: Arnd Bergmann I'd wait for Peter to give his final Ack here. Arnd

[PATCH V9 11/21] csky: Atomic operations

2018-10-15 Thread Guo Ren
This patch adds atomic, cmpxchg, spinlock files. Signed-off-by: Guo Ren Cc: Peter Zijlstra Cc: Andrea Parri Cc: Arnd Bergmann --- Changlog: - SMP supported - ticklock supported - queue-rwlock supported --- --- arch/csky/include/asm/atomic.h | 212 +

[PATCH V9 11/21] csky: Atomic operations

2018-10-15 Thread Guo Ren
This patch adds atomic, cmpxchg, spinlock files. Signed-off-by: Guo Ren Cc: Peter Zijlstra Cc: Andrea Parri Cc: Arnd Bergmann --- Changlog: - SMP supported - ticklock supported - queue-rwlock supported --- --- arch/csky/include/asm/atomic.h | 212 +