Re: [PATCH V9 3/8] clocksource: add C-SKY SMP timer

2018-10-04 Thread Guo Ren
On Tue, Oct 02, 2018 at 09:59:42AM +0200, Daniel Lezcano wrote: > On 02/10/2018 07:40, Guo Ren wrote: > [ ... ] > > >> > >>irq = irq_of_parse_and_map(np, 0); > >>if (irq <= 0) > >>return -EINVAL; > > panic(); > > I want a panic here. Return will make debug confused

Re: [PATCH V9 3/8] clocksource: add C-SKY SMP timer

2018-10-02 Thread Daniel Lezcano
On 02/10/2018 07:40, Guo Ren wrote: [ ... ] >> >> irq = irq_of_parse_and_map(np, 0); >> if (irq <= 0) >> return -EINVAL; > panic(); > I want a panic here. Return will make debug confused and directly tell > the people where is wrong. It's root-timer for us and

Re: [PATCH V9 3/8] clocksource: add C-SKY SMP timer

2018-10-01 Thread Guo Ren
On Mon, Oct 01, 2018 at 11:14:14AM +0200, Daniel Lezcano wrote: > On 01/10/2018 03:35, Guo Ren wrote: > > This timer is used by SMP system and use mfcr/mtcr instruction > > to access the regs. > > > > Changelog: > > - Remove #define CPUHP_AP_CSKY_TIMER_STARTING > > - Add CPUHP_AP_CSKY_TIMER_STAR

Re: [PATCH V9 3/8] clocksource: add C-SKY SMP timer

2018-10-01 Thread Daniel Lezcano
On 01/10/2018 03:35, Guo Ren wrote: > This timer is used by SMP system and use mfcr/mtcr instruction > to access the regs. > > Changelog: > - Remove #define CPUHP_AP_CSKY_TIMER_STARTING > - Add CPUHP_AP_CSKY_TIMER_STARTING in cpuhotplug.h > - Support csky mp timer alpha version. > - Just use l

[PATCH V9 3/8] clocksource: add C-SKY SMP timer

2018-09-30 Thread Guo Ren
This timer is used by SMP system and use mfcr/mtcr instruction to access the regs. Changelog: - Remove #define CPUHP_AP_CSKY_TIMER_STARTING - Add CPUHP_AP_CSKY_TIMER_STARTING in cpuhotplug.h - Support csky mp timer alpha version. - Just use low-counter with 32bit width as clocksource. - Codin