Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Sinan Kaya
On 7/18/2016 1:32 PM, Alex Williamson wrote: > The implementation looks pretty fixed, it seems like a lot would break > if that were changed, so the callers of the function would need to be > updated, including this one. The ternary below is already paranoid > enough to handle an API change, but i

Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Alex Williamson
On Fri, 15 Jul 2016 21:27:24 -0400 Sinan Kaya wrote: > On 7/14/2016 5:41 PM, Alex Williamson wrote: > > On Wed, 13 Jul 2016 22:06:30 -0400 > > Sinan Kaya wrote: > > > >> The code is using the compatible DT string to associate a reset driver > >> with the actual device itself. The compatible s

Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe

2016-07-15 Thread Sinan Kaya
On 7/14/2016 5:41 PM, Alex Williamson wrote: > On Wed, 13 Jul 2016 22:06:30 -0400 > Sinan Kaya wrote: > >> The code is using the compatible DT string to associate a reset driver >> with the actual device itself. The compatible string does not exist on >> ACPI based systems. HID is the unique iden

Re: [PATCH V9 4/9] vfio: platform: add support for ACPI probe

2016-07-14 Thread Alex Williamson
On Wed, 13 Jul 2016 22:06:30 -0400 Sinan Kaya wrote: > The code is using the compatible DT string to associate a reset driver > with the actual device itself. The compatible string does not exist on > ACPI based systems. HID is the unique identifier for a device driver > instead. > > Signed-off-

[PATCH V9 4/9] vfio: platform: add support for ACPI probe

2016-07-13 Thread Sinan Kaya
The code is using the compatible DT string to associate a reset driver with the actual device itself. The compatible string does not exist on ACPI based systems. HID is the unique identifier for a device driver instead. Signed-off-by: Sinan Kaya Reviewed-by: Eric Auger Reviewed-by: Baptiste Reyn