Re: [PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

2018-11-02 Thread Sven Van Asbroeck
On Thu, Nov 1, 2018 at 5:53 PM Linus Walleij wrote: > > On Thu, Nov 1, 2018 at 6:17 PM Sven Van Asbroeck wrote: > > Perhaps there is another kernel abstraction I could use? > > Maybe the properties should be on the bus though? I don't know :/ Let's keep the version associated with the bridge. Af

Re: [PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

2018-11-01 Thread Linus Walleij
On Thu, Nov 1, 2018 at 6:17 PM Sven Van Asbroeck wrote: > >> +static DEVICE_ATTR_RO(version); > > > > Do you need this in userspace really? > > > >> +static DEVICE_ATTR_RO(design_number); > > > > And this? > > Unfortunately, I do :( > The application software reads these out and displays them in

Re: [PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

2018-11-01 Thread Sven Van Asbroeck
Hi Linus, > This is fun :) It sure is ! It's fascinating to see how the kernel abstractions are designed, and how code is reviewed here. >> +static DEVICE_ATTR_RO(version); > > Do you need this in userspace really? > >> +static DEVICE_ATTR_RO(design_number); > > And this? Unfortunately, I do :(

Re: [PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

2018-10-31 Thread Linus Walleij
Hi Sven, On Wed, Oct 31, 2018 at 8:44 PM wrote: > From: Sven Van Asbroeck > > Add a driver for the Arcx anybus bridge. > > This chip embeds up to two Anybus-S application connectors > (slots), and connects to the SoC via a parallel memory bus. > There is also a CAN power readout, unrelated to t

[PATCH anybus v2 1/5] misc: support the Arcx anybus bridge.

2018-10-31 Thread thesven73
From: Sven Van Asbroeck Add a driver for the Arcx anybus bridge. This chip embeds up to two Anybus-S application connectors (slots), and connects to the SoC via a parallel memory bus. There is also a CAN power readout, unrelated to the Anybus. Signed-off-by: Sven Van Asbroeck --- drivers/misc