Re: [PATCH blktests v2 02/11] common/xfs: Create common helper to check for XFS support

2020-10-06 Thread Chaitanya Kulkarni
On 10/6/20 16:51, Logan Gunthorpe wrote: > _have_xfs() does return true/false and can be used with && or in a > conditional. > > Per [1], my opinion is that using && in the requires() function where > the return value is ignored is confusing so I prefer not to do it in new > code. > > If we want to

Re: [PATCH blktests v2 02/11] common/xfs: Create common helper to check for XFS support

2020-10-06 Thread Logan Gunthorpe
On 2020-10-06 5:44 p.m., Chaitanya Kulkarni wrote: > On 9/30/20 11:54, Logan Gunthorpe wrote: >> >> requires() { >> _nvme_requires >> -_have_program mkfs.xfs && _have_fio >> +_have_xfs >> +_have_fio > Can you make _have_xfs return true false ? so it can be used with && ? _ha

Re: [PATCH blktests v2 02/11] common/xfs: Create common helper to check for XFS support

2020-10-06 Thread Chaitanya Kulkarni
On 9/30/20 11:54, Logan Gunthorpe wrote: > > requires() { > _nvme_requires > - _have_program mkfs.xfs && _have_fio > + _have_xfs > + _have_fio Can you make _have_xfs return true false ? so it can be used with && ?

[PATCH blktests v2 02/11] common/xfs: Create common helper to check for XFS support

2020-09-30 Thread Logan Gunthorpe
Two nvme tests create and mount XFS filesystems and check for mkfs.xfs. They should also check for XFS support in the kernel so create a common helper for this. Signed-off-by: Logan Gunthorpe --- common/rc | 8 common/xfs | 11 +++ tests/nvme/012 | 6 -- tests/nv