Re: [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format

2019-09-27 Thread Daniel Xu
Hi Jiri, On Tue Sep 24, 2019 at 10:33 AM Jiri Olsa wrote: > On Tue, Sep 17, 2019 at 06:30:52AM -0700, Daniel Xu wrote: > > SNIP > > > + PERF_FORMAT_MAX = 1U << 5, /* non-ABI */ > > }; > > > > #define PERF_ATTR_SIZE_VER064 /* sizeof first published > > struct */

Re: [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format

2019-09-24 Thread Jiri Olsa
On Tue, Sep 17, 2019 at 06:30:52AM -0700, Daniel Xu wrote: SNIP > + PERF_FORMAT_MAX = 1U << 5, /* non-ABI */ > }; > > #define PERF_ATTR_SIZE_VER0 64 /* sizeof first published struct */ > diff --git a/kernel/events/core.c b/kernel/events/core.c > index

Re: [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format

2019-09-17 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Daniel-Xu/perf-core-Add-PERF_FORMAT_LOST-read_format/20190917-213515 base:

Re: [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format

2019-09-17 Thread Daniel Xu
On Tue Sep 17, 2019 at 10:32 PM kbuild test robot wrote: > All errors (new ones prefixed by >>): > >kernel/events/core.c: In function 'perf_event_lost': > >> kernel/events/core.c:4753:11: error: implicit declaration of function > >> 'perf_kprobe_missed'; did you mean 'perf_release'? > >>

Re: [PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format

2019-09-17 Thread kbuild test robot
Hi Daniel, Thank you for the patch! Yet something to improve: [auto build test ERROR on bpf-next/master] url: https://github.com/0day-ci/linux/commits/Daniel-Xu/perf-core-Add-PERF_FORMAT_LOST-read_format/20190917-213515 base:

[PATCH bpf-next 1/5] perf/core: Add PERF_FORMAT_LOST read_format

2019-09-17 Thread Daniel Xu
It's useful to know kprobe's nmissed count. For example with tracing tools, it's important to know when events may have been lost. debugfs currently exposes a control file to get this information, but it is not compatible with probes registered with the perf API. While bpf programs may be able