Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-26 Thread Jiri Olsa
On Thu, Jan 14, 2021 at 07:47:20PM -0800, Alexei Starovoitov wrote: > On Thu, Jan 14, 2021 at 3:44 PM Yonghong Song wrote: > > > > > > > > On 1/14/21 2:02 PM, Jiri Olsa wrote: > > > On Thu, Jan 14, 2021 at 01:05:33PM -0800, Yonghong Song wrote: > > >> > > >> > > >> On 1/14/21 12:01 PM, Jiri Olsa w

Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-26 Thread Yonghong Song
On 1/26/21 12:52 PM, Jiri Olsa wrote: On Thu, Jan 14, 2021 at 07:47:20PM -0800, Alexei Starovoitov wrote: On Thu, Jan 14, 2021 at 3:44 PM Yonghong Song wrote: On 1/14/21 2:02 PM, Jiri Olsa wrote: On Thu, Jan 14, 2021 at 01:05:33PM -0800, Yonghong Song wrote: On 1/14/21 12:01 PM, Jiri

Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-14 Thread Alexei Starovoitov
On Thu, Jan 14, 2021 at 3:44 PM Yonghong Song wrote: > > > > On 1/14/21 2:02 PM, Jiri Olsa wrote: > > On Thu, Jan 14, 2021 at 01:05:33PM -0800, Yonghong Song wrote: > >> > >> > >> On 1/14/21 12:01 PM, Jiri Olsa wrote: > >>> On Thu, Jan 14, 2021 at 10:56:33AM -0800, Yonghong Song wrote: > > >>

Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-14 Thread Yonghong Song
On 1/14/21 2:02 PM, Jiri Olsa wrote: On Thu, Jan 14, 2021 at 01:05:33PM -0800, Yonghong Song wrote: On 1/14/21 12:01 PM, Jiri Olsa wrote: On Thu, Jan 14, 2021 at 10:56:33AM -0800, Yonghong Song wrote: On 1/14/21 5:40 AM, Jiri Olsa wrote: It's possible to have other build id types (othe

Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-14 Thread Jiri Olsa
On Thu, Jan 14, 2021 at 01:05:33PM -0800, Yonghong Song wrote: > > > On 1/14/21 12:01 PM, Jiri Olsa wrote: > > On Thu, Jan 14, 2021 at 10:56:33AM -0800, Yonghong Song wrote: > > > > > > > > > On 1/14/21 5:40 AM, Jiri Olsa wrote: > > > > It's possible to have other build id types (other than def

Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-14 Thread Yonghong Song
On 1/14/21 12:01 PM, Jiri Olsa wrote: On Thu, Jan 14, 2021 at 10:56:33AM -0800, Yonghong Song wrote: On 1/14/21 5:40 AM, Jiri Olsa wrote: It's possible to have other build id types (other than default SHA1). Currently there's also ld support for MD5 build id. Currently, bpf build_id base

Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-14 Thread Jiri Olsa
On Thu, Jan 14, 2021 at 10:56:33AM -0800, Yonghong Song wrote: > > > On 1/14/21 5:40 AM, Jiri Olsa wrote: > > It's possible to have other build id types (other than default SHA1). > > Currently there's also ld support for MD5 build id. > > Currently, bpf build_id based stackmap does not returns

Re: [PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-14 Thread Yonghong Song
On 1/14/21 5:40 AM, Jiri Olsa wrote: It's possible to have other build id types (other than default SHA1). Currently there's also ld support for MD5 build id. Currently, bpf build_id based stackmap does not returns the size of the build_id. Did you see an issue here? I guess user space can c

[PATCH bpf-next 2/3] bpf: Add size arg to build_id_parse function

2021-01-14 Thread Jiri Olsa
It's possible to have other build id types (other than default SHA1). Currently there's also ld support for MD5 build id. Adding size argument to build_id_parse function, that returns (if defined) size of the parsed build id, so we can recognize the build id type. Cc: Alexei Starovoitov Cc: Song