Re: [PATCH bpf-next v3 13/14] bpf: Add tests for new BPF atomic operations

2020-12-07 Thread Brendan Jackman
On Fri, Dec 04, 2020 at 11:49:22AM -0800, Andrii Nakryiko wrote: > On Fri, Dec 4, 2020 at 7:29 AM Yonghong Song wrote: > > > > > > > > On 12/4/20 1:45 AM, Brendan Jackman wrote: > > > On Thu, Dec 03, 2020 at 11:06:31PM -0800, Yonghong Song wrote: > > >> On 12/3/20 8:02 AM, Brendan Jackman wrote: >

Re: [PATCH bpf-next v3 13/14] bpf: Add tests for new BPF atomic operations

2020-12-04 Thread Andrii Nakryiko
On Fri, Dec 4, 2020 at 7:29 AM Yonghong Song wrote: > > > > On 12/4/20 1:45 AM, Brendan Jackman wrote: > > On Thu, Dec 03, 2020 at 11:06:31PM -0800, Yonghong Song wrote: > >> On 12/3/20 8:02 AM, Brendan Jackman wrote: > > [...] > >>> diff --git a/tools/testing/selftests/bpf/prog_tests/atomics_test

Re: [PATCH bpf-next v3 13/14] bpf: Add tests for new BPF atomic operations

2020-12-04 Thread Yonghong Song
On 12/4/20 1:45 AM, Brendan Jackman wrote: On Thu, Dec 03, 2020 at 11:06:31PM -0800, Yonghong Song wrote: On 12/3/20 8:02 AM, Brendan Jackman wrote: [...] diff --git a/tools/testing/selftests/bpf/prog_tests/atomics_test.c b/tools/testing/selftests/bpf/prog_tests/atomics_test.c new file mod

Re: [PATCH bpf-next v3 13/14] bpf: Add tests for new BPF atomic operations

2020-12-04 Thread Brendan Jackman
On Thu, Dec 03, 2020 at 11:06:31PM -0800, Yonghong Song wrote: > On 12/3/20 8:02 AM, Brendan Jackman wrote: [...] > > diff --git a/tools/testing/selftests/bpf/prog_tests/atomics_test.c > > b/tools/testing/selftests/bpf/prog_tests/atomics_test.c > > new file mode 100644 > > index ..66f0

Re: [PATCH bpf-next v3 13/14] bpf: Add tests for new BPF atomic operations

2020-12-03 Thread Yonghong Song
On 12/3/20 8:02 AM, Brendan Jackman wrote: This relies on the work done by Yonghong Song in https://reviews.llvm.org/D72184 Note the use of a define called ENABLE_ATOMICS_TESTS: this is used to: - Avoid breaking the build for people on old versions of Clang - Avoid needing separate lists

[PATCH bpf-next v3 13/14] bpf: Add tests for new BPF atomic operations

2020-12-03 Thread Brendan Jackman
This relies on the work done by Yonghong Song in https://reviews.llvm.org/D72184 Note the use of a define called ENABLE_ATOMICS_TESTS: this is used to: - Avoid breaking the build for people on old versions of Clang - Avoid needing separate lists of test objects for no_alu32, where atomics ar