Re: [PATCH bpf-next v4 0/6] bpf: BTF support for ksyms

2020-10-02 Thread Hao Luo
Thanks, Alexei and Andrii and other reviewers for the comments. It's a pleasure to work with you and contribute to bpf. Hao On Fri, Oct 2, 2020 at 3:16 PM Alexei Starovoitov wrote: > > On Tue, Sep 29, 2020 at 11:48 PM Hao Luo wrote: > > > > Ah, this is the bug in pahole described in > >

Re: [PATCH bpf-next v4 0/6] bpf: BTF support for ksyms

2020-10-02 Thread Alexei Starovoitov
On Tue, Sep 29, 2020 at 11:48 PM Hao Luo wrote: > > Ah, this is the bug in pahole described in > https://lkml.org/lkml/2020/8/20/1862. I proposed a fix [1] but it > hasn't reached pahole's master branch. Let me ask Arnaldo to see if he > is OK merging it. > > [1]

Re: [PATCH bpf-next v4 0/6] bpf: BTF support for ksyms

2020-09-30 Thread Hao Luo
Ah, this is the bug in pahole described in https://lkml.org/lkml/2020/8/20/1862. I proposed a fix [1] but it hasn't reached pahole's master branch. Let me ask Arnaldo to see if he is OK merging it. [1] https://www.spinics.net/lists/dwarves/msg00451.html On Tue, Sep 29, 2020 at 9:36 PM Alexei

Re: [PATCH bpf-next v4 0/6] bpf: BTF support for ksyms

2020-09-29 Thread Alexei Starovoitov
On Tue, Sep 29, 2020 at 4:50 PM Hao Luo wrote: > > v3 -> v4: > - Rebasing > - Cast bpf_[per|this]_cpu_ptr's parameter to void __percpu * before >passing into per_cpu_ptr. Looks good, but doesn't work: ./test_progs -t ksyms_btf test_ksyms_btf:PASS:kallsyms_fopen 0 nsec

[PATCH bpf-next v4 0/6] bpf: BTF support for ksyms

2020-09-29 Thread Hao Luo
v3 -> v4: - Rebasing - Cast bpf_[per|this]_cpu_ptr's parameter to void __percpu * before passing into per_cpu_ptr. v2 -> v3: - Rename functions and variables in verifier for better readability. - Stick to logging message convention in libbpf. - Move bpf_per_cpu_ptr and bpf_this_cpu_ptr