Re: [PATCH can-next v4] can: add tx/rx LED trigger support

2012-08-01 Thread Marc Kleine-Budde
On 08/01/2012 12:30 PM, Fabio Baltieri wrote: [...] >>> +void can_led_init(struct net_device *netdev) >>> +{ >>> + struct can_priv *priv = netdev_priv(netdev); >>> + void *res; >>> + >>> + res = devres_alloc(can_led_release, 0, GFP_KERNEL); >> ^ >>

Re: [PATCH can-next v4] can: add tx/rx LED trigger support

2012-08-01 Thread Fabio Baltieri
On Wed, Aug 01, 2012 at 11:36:51AM +0200, Marc Kleine-Budde wrote: > On 08/01/2012 12:05 AM, Fabio Baltieri wrote: > > This patch implements the functions to add two LED triggers, named > > -tx and -rx, to a canbus device driver. > > > > Triggers are called from specific handlers by each CAN devic

Re: [PATCH can-next v4] can: add tx/rx LED trigger support

2012-08-01 Thread Marc Kleine-Budde
On 08/01/2012 11:36 AM, Marc Kleine-Budde wrote: [...] >> +/* >> + * Register CAN LED triggers for a CAN device >> + * >> + * This is normally called from a driver's probe function >> + */ >> +void can_led_init(struct net_device *netdev) >> +{ >> +struct can_priv *priv = netdev_priv(netdev); >

Re: [PATCH can-next v4] can: add tx/rx LED trigger support

2012-08-01 Thread Marc Kleine-Budde
On 08/01/2012 12:05 AM, Fabio Baltieri wrote: > This patch implements the functions to add two LED triggers, named > -tx and -rx, to a canbus device driver. > > Triggers are called from specific handlers by each CAN device driver and > can be disabled altogether with a Kconfig option. > > The imp

[PATCH can-next v4] can: add tx/rx LED trigger support

2012-07-31 Thread Fabio Baltieri
This patch implements the functions to add two LED triggers, named -tx and -rx, to a canbus device driver. Triggers are called from specific handlers by each CAN device driver and can be disabled altogether with a Kconfig option. The implementation keeps the LED on when the interface is UP and bl