Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert "cgroup: Remove task_lock() from cgroup_post_fork()"

2012-10-22 Thread Frederic Weisbecker
2012/10/21 Tejun Heo : > Hello, Frederic. > > On Sat, Oct 20, 2012 at 02:21:43PM -0400, Frederic Weisbecker wrote: >> CPU 0 >> CPU 1 >> >> cgroup_task_migrate { >> task_lock(p) >> rcu_assign_pointer(tsk->cgroups, newcg); >> task_unlock(tsk); >> >>

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert cgroup: Remove task_lock() from cgroup_post_fork()

2012-10-22 Thread Frederic Weisbecker
2012/10/21 Tejun Heo t...@kernel.org: Hello, Frederic. On Sat, Oct 20, 2012 at 02:21:43PM -0400, Frederic Weisbecker wrote: CPU 0 CPU 1 cgroup_task_migrate { task_lock(p) rcu_assign_pointer(tsk-cgroups, newcg); task_unlock(tsk);

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert "cgroup: Remove task_lock() from cgroup_post_fork()"

2012-10-20 Thread Tejun Heo
Hello, Frederic. On Sat, Oct 20, 2012 at 02:21:43PM -0400, Frederic Weisbecker wrote: > CPU 0 > CPU 1 > > cgroup_task_migrate { > task_lock(p) > rcu_assign_pointer(tsk->cgroups, newcg); > task_unlock(tsk); > > write_lock(_set_lock); >

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert "cgroup: Remove task_lock() from cgroup_post_fork()"

2012-10-20 Thread Frederic Weisbecker
2012/10/20 Frederic Weisbecker : > 2012/10/19 Tejun Heo : >> Hello, Frederic. >> >> On Fri, Oct 19, 2012 at 03:44:20PM -0400, Frederic Weisbecker wrote: >>> > For -stable, I think it's better to revert. If you want to remove >>> > task_lock, let's do it for 3.8. >>> >>> I don't think that a wrong

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert "cgroup: Remove task_lock() from cgroup_post_fork()"

2012-10-20 Thread Frederic Weisbecker
2012/10/19 Tejun Heo : > Hello, Frederic. > > On Fri, Oct 19, 2012 at 03:44:20PM -0400, Frederic Weisbecker wrote: >> > For -stable, I think it's better to revert. If you want to remove >> > task_lock, let's do it for 3.8. >> >> I don't think that a wrong comment justifies a patch to stable. > >

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert cgroup: Remove task_lock() from cgroup_post_fork()

2012-10-20 Thread Frederic Weisbecker
2012/10/19 Tejun Heo t...@kernel.org: Hello, Frederic. On Fri, Oct 19, 2012 at 03:44:20PM -0400, Frederic Weisbecker wrote: For -stable, I think it's better to revert. If you want to remove task_lock, let's do it for 3.8. I don't think that a wrong comment justifies a patch to stable.

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert cgroup: Remove task_lock() from cgroup_post_fork()

2012-10-20 Thread Frederic Weisbecker
2012/10/20 Frederic Weisbecker fweis...@gmail.com: 2012/10/19 Tejun Heo t...@kernel.org: Hello, Frederic. On Fri, Oct 19, 2012 at 03:44:20PM -0400, Frederic Weisbecker wrote: For -stable, I think it's better to revert. If you want to remove task_lock, let's do it for 3.8. I don't think

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert cgroup: Remove task_lock() from cgroup_post_fork()

2012-10-20 Thread Tejun Heo
Hello, Frederic. On Sat, Oct 20, 2012 at 02:21:43PM -0400, Frederic Weisbecker wrote: CPU 0 CPU 1 cgroup_task_migrate { task_lock(p) rcu_assign_pointer(tsk-cgroups, newcg); task_unlock(tsk); write_lock(css_set_lock); if

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert "cgroup: Remove task_lock() from cgroup_post_fork()"

2012-10-19 Thread Tejun Heo
Hello, Frederic. On Fri, Oct 19, 2012 at 03:44:20PM -0400, Frederic Weisbecker wrote: > > For -stable, I think it's better to revert. If you want to remove > > task_lock, let's do it for 3.8. > > I don't think that a wrong comment justifies a patch to stable. I'm not really sure whether it's

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert "cgroup: Remove task_lock() from cgroup_post_fork()"

2012-10-19 Thread Frederic Weisbecker
2012/10/19 Tejun Heo : > On Fri, Oct 19, 2012 at 09:35:26AM -0400, Frederic Weisbecker wrote: >> 2012/10/18 Tejun Heo : >> > From d935a5d6832a264ce52f4257e176f4f96cbaf048 Mon Sep 17 00:00:00 2001 >> > From: Tejun Heo >> > Date: Thu, 18 Oct 2012 17:40:30 -0700 >> > >> > This reverts commit

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert cgroup: Remove task_lock() from cgroup_post_fork()

2012-10-19 Thread Frederic Weisbecker
2012/10/19 Tejun Heo t...@kernel.org: On Fri, Oct 19, 2012 at 09:35:26AM -0400, Frederic Weisbecker wrote: 2012/10/18 Tejun Heo t...@kernel.org: From d935a5d6832a264ce52f4257e176f4f96cbaf048 Mon Sep 17 00:00:00 2001 From: Tejun Heo t...@kernel.org Date: Thu, 18 Oct 2012 17:40:30 -0700

Re: [PATCH cgroup/for-3.7-fixes 1/2] Revert cgroup: Remove task_lock() from cgroup_post_fork()

2012-10-19 Thread Tejun Heo
Hello, Frederic. On Fri, Oct 19, 2012 at 03:44:20PM -0400, Frederic Weisbecker wrote: For -stable, I think it's better to revert. If you want to remove task_lock, let's do it for 3.8. I don't think that a wrong comment justifies a patch to stable. I'm not really sure whether it's safe or