Re: [PATCH consolidate sys_ptrace

2005-11-04 Thread Christoph Hellwig
On Tue, Nov 01, 2005 at 11:37:54AM +, David Howells wrote: > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > The sys_ptrace boilerplate code (everything outside the big switch > > > statement for the arch-specific requests) is shared by most > > > architectures. This patch moves it to

Re: [PATCH consolidate sys_ptrace

2005-11-04 Thread Christoph Hellwig
On Tue, Nov 01, 2005 at 11:37:54AM +, David Howells wrote: Christoph Hellwig [EMAIL PROTECTED] wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to

Re: [PATCH consolidate sys_ptrace

2005-11-02 Thread Paul Mundt
On Tue, Nov 01, 2005 at 06:12:21AM +0100, Christoph Hellwig wrote: > On Tue, Nov 01, 2005 at 06:09:00AM +0100, Christoph Hellwig wrote: > > Some architectures have a too different ptrace so we have to exclude > > them. They continue to keep their implementations. For sh64 I had to > > add a

Re: [PATCH consolidate sys_ptrace

2005-11-02 Thread Paul Mundt
On Tue, Nov 01, 2005 at 06:12:21AM +0100, Christoph Hellwig wrote: On Tue, Nov 01, 2005 at 06:09:00AM +0100, Christoph Hellwig wrote: Some architectures have a too different ptrace so we have to exclude them. They continue to keep their implementations. For sh64 I had to add a sh64_ptrace

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Andrew Morton
David Howells <[EMAIL PROTECTED]> wrote: > > Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > The sys_ptrace boilerplate code (everything outside the big switch > > > statement for the arch-specific requests) is shared by most > > > architectures. This patch moves it to kernel/ptrace.c and

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Russell King
On Tue, Nov 01, 2005 at 06:12:21AM +0100, Christoph Hellwig wrote: > On Tue, Nov 01, 2005 at 06:09:00AM +0100, Christoph Hellwig wrote: > > [Let's try again now that sys_ptrace returns long everywhere mainline..] > > > > The sys_ptrace boilerplate code (everything outside the big switch > >

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread David Howells
Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > The sys_ptrace boilerplate code (everything outside the big switch > > statement for the arch-specific requests) is shared by most > > architectures. This patch moves it to kernel/ptrace.c and leaves the > > arch-specific code as arch_ptrace.

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Ralf Baechle
On Tue, Nov 01, 2005 at 06:12:21AM +0100, Christoph Hellwig wrote: > Umm, it might be a good idea to actually send the current patch instead > of the old one. I really should write this text from scratch instead > of copying it :) > > > Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]>

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Paul Mackerras
Christoph Hellwig writes: > > Some architectures have a too different ptrace so we have to exclude > > them. They continue to keep their implementations. For sh64 I had to > > add a sh64_ptrace wrapper because it does some initialization on the > > first call. For um I removed an ifdefed

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Paul Mackerras
Christoph Hellwig writes: Some architectures have a too different ptrace so we have to exclude them. They continue to keep their implementations. For sh64 I had to add a sh64_ptrace wrapper because it does some initialization on the first call. For um I removed an ifdefed

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Ralf Baechle
On Tue, Nov 01, 2005 at 06:12:21AM +0100, Christoph Hellwig wrote: Umm, it might be a good idea to actually send the current patch instead of the old one. I really should write this text from scratch instead of copying it :) Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread David Howells
Christoph Hellwig [EMAIL PROTECTED] wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as arch_ptrace. Looks okay to

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Russell King
On Tue, Nov 01, 2005 at 06:12:21AM +0100, Christoph Hellwig wrote: On Tue, Nov 01, 2005 at 06:09:00AM +0100, Christoph Hellwig wrote: [Let's try again now that sys_ptrace returns long everywhere mainline..] The sys_ptrace boilerplate code (everything outside the big switch statement for

Re: [PATCH consolidate sys_ptrace

2005-11-01 Thread Andrew Morton
David Howells [EMAIL PROTECTED] wrote: Christoph Hellwig [EMAIL PROTECTED] wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the

Re: [PATCH consolidate sys_ptrace

2005-10-31 Thread Christoph Hellwig
On Tue, Nov 01, 2005 at 06:09:00AM +0100, Christoph Hellwig wrote: > [Let's try again now that sys_ptrace returns long everywhere mainline..] > > The sys_ptrace boilerplate code (everything outside the big switch > statement for the arch-specific requests) is shared by most > architectures. This

[PATCH consolidate sys_ptrace

2005-10-31 Thread Christoph Hellwig
[Let's try again now that sys_ptrace returns long everywhere mainline..] The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as

[PATCH consolidate sys_ptrace

2005-10-31 Thread Christoph Hellwig
[Let's try again now that sys_ptrace returns long everywhere mainline..] The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as

Re: [PATCH consolidate sys_ptrace

2005-10-31 Thread Christoph Hellwig
On Tue, Nov 01, 2005 at 06:09:00AM +0100, Christoph Hellwig wrote: [Let's try again now that sys_ptrace returns long everywhere mainline..] The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Christoph Hellwig
On Thu, Aug 11, 2005 at 10:32:03AM -0700, Richard Henderson wrote: > On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: > > The sys_ptrace boilerplate code (everything outside the big switch > > statement for the arch-specific requests) is shared by most > > architectures. This

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Richard Henderson
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: > The sys_ptrace boilerplate code (everything outside the big switch > statement for the arch-specific requests) is shared by most > architectures. This patch moves it to kernel/ptrace.c and leaves the > arch-specific code as

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Russell King
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: > Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Acked-by: Russell King <[EMAIL PROTECTED]> Thanks Christoph. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Christoph Hellwig
On Thu, Aug 11, 2005 at 12:44:34PM +0200, Roman Zippel wrote: > No objection really, but I recently reformatted the m68k sys_ptrace() so > it would be easier to regenerate your changes on top of this. I can do > this for you if we can agree on to merge at least the m68k ptrace changes > before

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Roman Zippel
Hi, On Wed, 10 Aug 2005, Christoph Hellwig wrote: > The sys_ptrace boilerplate code (everything outside the big switch > statement for the arch-specific requests) is shared by most > architectures. This patch moves it to kernel/ptrace.c and leaves the > arch-specific code as arch_ptrace. No

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Roman Zippel
Hi, On Wed, 10 Aug 2005, Christoph Hellwig wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as arch_ptrace. No

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Christoph Hellwig
On Thu, Aug 11, 2005 at 12:44:34PM +0200, Roman Zippel wrote: No objection really, but I recently reformatted the m68k sys_ptrace() so it would be easier to regenerate your changes on top of this. I can do this for you if we can agree on to merge at least the m68k ptrace changes before

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Russell King
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Acked-by: Russell King [EMAIL PROTECTED] Thanks Christoph. -- Russell King Linux kernel2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Richard Henderson
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as

Re: [PATCH] consolidate sys_ptrace

2005-08-11 Thread Christoph Hellwig
On Thu, Aug 11, 2005 at 10:32:03AM -0700, Richard Henderson wrote: On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Stephen Rothwell
On Wed, 10 Aug 2005 09:59:01 -0700 "Luck, Tony" <[EMAIL PROTECTED]> wrote: > > >Some architectures have a too different ptrace so we have to exclude > >them: alpha, ia64, m32r, parisc, sparc, sparc64. They continue to > >keep their implementations. > > So it should be no surprise that this patch

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Richard Henderson
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: > Some architectures have a too different ptrace so we have to exclude > them: alpha... Alpha could be updated to use this, I think. Just a matter of using force_successful_syscall_return instead of pt_regs directly. I'll have a

RE: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Luck, Tony
>Some architectures have a too different ptrace so we have to exclude >them: alpha, ia64, m32r, parisc, sparc, sparc64. They continue to >keep their implementations. So it should be no surprise that this patch works ok for ia64, but here is the ACK anyway. >+#ifndef __ARCH_SYS_PTRACE Most of

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Jeff Dike
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: > The sys_ptrace boilerplate code (everything outside the big switch > statement for the arch-specific requests) is shared by most > architectures. This patch moves it to kernel/ptrace.c and leaves the > arch-specific code as

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Ralf Baechle
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: > The sys_ptrace boilerplate code (everything outside the big switch > statement for the arch-specific requests) is shared by most > architectures. This patch moves it to kernel/ptrace.c and leaves the > arch-specific code as

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Paul Mundt
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: > Some architectures have a too different ptrace so we have to exclude > them: alpha, ia64, m32r, parisc, sparc, sparc64. They continue to > keep their implementations. For sh64 I had to add a sh64_ptrace wrapper > because it

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread David Howells
Christoph Hellwig <[EMAIL PROTECTED]> wrote: > The sys_ptrace boilerplate code (everything outside the big switch > statement for the arch-specific requests) is shared by most > architectures. This patch moves it to kernel/ptrace.c and leaves the > arch-specific code as arch_ptrace. Looks okay

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Andi Kleen
x86-64 part is ok for me. -Andi

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Christoph Hellwig
On Wed, Aug 10, 2005 at 10:33:50AM +0200, Martin Schwidefsky wrote: > Christoph Hellwig <[EMAIL PROTECTED]> wrote on 08/10/2005 10:00:57 AM: > > > The sys_ptrace boilerplate code (everything outside the big switch > > statement for the arch-specific requests) is shared by most > > architectures.

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Martin Schwidefsky
Christoph Hellwig <[EMAIL PROTECTED]> wrote on 08/10/2005 10:00:57 AM: > The sys_ptrace boilerplate code (everything outside the big switch > statement for the arch-specific requests) is shared by most > architectures. This patch moves it to kernel/ptrace.c and leaves the > arch-specific code as

[PATCH] consolidate sys_ptrace

2005-08-10 Thread Christoph Hellwig
The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as arch_ptrace. Some architectures have a too different ptrace so we have to

[PATCH] consolidate sys_ptrace

2005-08-10 Thread Christoph Hellwig
The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as arch_ptrace. Some architectures have a too different ptrace so we have to

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Martin Schwidefsky
Christoph Hellwig [EMAIL PROTECTED] wrote on 08/10/2005 10:00:57 AM: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Christoph Hellwig
On Wed, Aug 10, 2005 at 10:33:50AM +0200, Martin Schwidefsky wrote: Christoph Hellwig [EMAIL PROTECTED] wrote on 08/10/2005 10:00:57 AM: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Andi Kleen
x86-64 part is ok for me. -Andi

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread David Howells
Christoph Hellwig [EMAIL PROTECTED] wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as arch_ptrace. Looks okay for

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Paul Mundt
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: Some architectures have a too different ptrace so we have to exclude them: alpha, ia64, m32r, parisc, sparc, sparc64. They continue to keep their implementations. For sh64 I had to add a sh64_ptrace wrapper because it does

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Ralf Baechle
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Jeff Dike
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: The sys_ptrace boilerplate code (everything outside the big switch statement for the arch-specific requests) is shared by most architectures. This patch moves it to kernel/ptrace.c and leaves the arch-specific code as

RE: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Luck, Tony
Some architectures have a too different ptrace so we have to exclude them: alpha, ia64, m32r, parisc, sparc, sparc64. They continue to keep their implementations. So it should be no surprise that this patch works ok for ia64, but here is the ACK anyway. +#ifndef __ARCH_SYS_PTRACE Most of the

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Richard Henderson
On Wed, Aug 10, 2005 at 10:00:57AM +0200, Christoph Hellwig wrote: Some architectures have a too different ptrace so we have to exclude them: alpha... Alpha could be updated to use this, I think. Just a matter of using force_successful_syscall_return instead of pt_regs directly. I'll have a

Re: [PATCH] consolidate sys_ptrace

2005-08-10 Thread Stephen Rothwell
On Wed, 10 Aug 2005 09:59:01 -0700 Luck, Tony [EMAIL PROTECTED] wrote: Some architectures have a too different ptrace so we have to exclude them: alpha, ia64, m32r, parisc, sparc, sparc64. They continue to keep their implementations. So it should be no surprise that this patch works ok for