Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-07 Thread Greg Kroah-Hartman
On Fri, Apr 06, 2018 at 09:35:35PM +0200, Arend van Spriel wrote: > Op vr 6 apr. 2018 4:46 PM schreef Greg Kroah-Hartman > : > > > > On Fri, Apr 06, 2018 at 12:13:38PM +0200, Arend van Spriel wrote: > > > On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman > > >

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-07 Thread Greg Kroah-Hartman
On Fri, Apr 06, 2018 at 09:35:35PM +0200, Arend van Spriel wrote: > Op vr 6 apr. 2018 4:46 PM schreef Greg Kroah-Hartman > : > > > > On Fri, Apr 06, 2018 at 12:13:38PM +0200, Arend van Spriel wrote: > > > On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman > > > wrote: > > > > On Sat, Mar 24,

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Arend van Spriel
Op vr 6 apr. 2018 4:46 PM schreef Greg Kroah-Hartman : > > On Fri, Apr 06, 2018 at 12:13:38PM +0200, Arend van Spriel wrote: > > On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman > > wrote: > > > On Sat, Mar 24, 2018 at 09:50:05AM +0100,

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Arend van Spriel
Op vr 6 apr. 2018 4:46 PM schreef Greg Kroah-Hartman : > > On Fri, Apr 06, 2018 at 12:13:38PM +0200, Arend van Spriel wrote: > > On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman > > wrote: > > > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: > > >> On Fri, Mar 23, 2018 at

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Greg Kroah-Hartman
On Fri, Apr 06, 2018 at 12:13:38PM +0200, Arend van Spriel wrote: > On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman > wrote: > > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: > >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman > >>

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Greg Kroah-Hartman
On Fri, Apr 06, 2018 at 12:13:38PM +0200, Arend van Spriel wrote: > On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman > wrote: > > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: > >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman > >> wrote: > >> > On Thu, Mar 15, 2018

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Arend van Spriel
On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman >> wrote: >> > On Thu, Mar 15, 2018 at 10:55:24AM +0100,

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-04-06 Thread Arend van Spriel
On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman >> wrote: >> > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: >> >> Upon submitting a patch

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Arend van Spriel
+ Marcel On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman >> wrote: >> > On Thu, Mar 15, 2018 at

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Arend van Spriel
+ Marcel On Sat, Mar 24, 2018 at 10:04 AM, Greg Kroah-Hartman wrote: > On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: >> On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman >> wrote: >> > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: >> >> Upon submitting

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Greg Kroah-Hartman
On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: > On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman > wrote: > > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: > >> Upon submitting a patch for mwifiex [1] it was discussed whether

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Greg Kroah-Hartman
On Sat, Mar 24, 2018 at 09:50:05AM +0100, Arend van Spriel wrote: > On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman > wrote: > > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: > >> Upon submitting a patch for mwifiex [1] it was discussed whether this > >> callback function

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Arend van Spriel
On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman wrote: > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: >> Upon submitting a patch for mwifiex [1] it was discussed whether this >> callback function could fail. To keep things simple there is no

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-24 Thread Arend van Spriel
On Fri, Mar 23, 2018 at 5:55 PM, Greg Kroah-Hartman wrote: > On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: >> Upon submitting a patch for mwifiex [1] it was discussed whether this >> callback function could fail. To keep things simple there is no need >> for the error code so

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: > Upon submitting a patch for mwifiex [1] it was discussed whether this > callback function could fail. To keep things simple there is no need > for the error code so the driver can do the task synchronous or not > without worries.

Re: [PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-23 Thread Greg Kroah-Hartman
On Thu, Mar 15, 2018 at 10:55:24AM +0100, Arend van Spriel wrote: > Upon submitting a patch for mwifiex [1] it was discussed whether this > callback function could fail. To keep things simple there is no need > for the error code so the driver can do the task synchronous or not > without worries.

[PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-15 Thread Arend van Spriel
Upon submitting a patch for mwifiex [1] it was discussed whether this callback function could fail. To keep things simple there is no need for the error code so the driver can do the task synchronous or not without worries. Currently the device driver core already ignores the return value so

[PATCH for-4.16 2/3] drivers: change struct device_driver::coredump() return type to void

2018-03-15 Thread Arend van Spriel
Upon submitting a patch for mwifiex [1] it was discussed whether this callback function could fail. To keep things simple there is no need for the error code so the driver can do the task synchronous or not without worries. Currently the device driver core already ignores the return value so