[PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-21 Thread Tejun Heo
mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec pages can be moved too. lru_add_drain_all() schedules and flushes work items on system_wq which depends on being able to create new kworkers to make forward progress. Since 1ed1328792ff ("sched, cgroup: replace

[PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-21 Thread Tejun Heo
mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec pages can be moved too. lru_add_drain_all() schedules and flushes work items on system_wq which depends on being able to create new kworkers to make forward progress. Since 1ed1328792ff ("sched, cgroup: replace

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-21 Thread Tejun Heo
On Thu, Apr 21, 2016 at 05:00:24PM +0200, Petr Mladek wrote: > > Acked-by: Michal Hocko > > Just for completeness. The problematic LTP test is running for hours > with this patch. Feel free to add: > > Tested-by: Petr Mladek Thanks, I'm gonna repost w/

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-21 Thread Tejun Heo
On Thu, Apr 21, 2016 at 05:00:24PM +0200, Petr Mladek wrote: > > Acked-by: Michal Hocko > > Just for completeness. The problematic LTP test is running for hours > with this patch. Feel free to add: > > Tested-by: Petr Mladek Thanks, I'm gonna repost w/ Andrew cc'd and the tags added. --

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-21 Thread Petr Mladek
On Wed 2016-04-20 23:27:05, Michal Hocko wrote: > On Wed 20-04-16 17:29:22, Tejun Heo wrote: > > Hello, Michal. > > > > On Sun, Apr 17, 2016 at 08:07:48AM -0400, Michal Hocko wrote: > [...] > > > I liked your proposal when mem_cgroup_move_charge would be called from a > > > context which doesn't

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-21 Thread Petr Mladek
On Wed 2016-04-20 23:27:05, Michal Hocko wrote: > On Wed 20-04-16 17:29:22, Tejun Heo wrote: > > Hello, Michal. > > > > On Sun, Apr 17, 2016 at 08:07:48AM -0400, Michal Hocko wrote: > [...] > > > I liked your proposal when mem_cgroup_move_charge would be called from a > > > context which doesn't

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-20 Thread Michal Hocko
On Wed 20-04-16 17:29:22, Tejun Heo wrote: > Hello, Michal. > > On Sun, Apr 17, 2016 at 08:07:48AM -0400, Michal Hocko wrote: [...] > > I liked your proposal when mem_cgroup_move_charge would be called from a > > context which doesn't hold the problematic rwsem much more. Would that > > be too

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-20 Thread Michal Hocko
On Wed 20-04-16 17:29:22, Tejun Heo wrote: > Hello, Michal. > > On Sun, Apr 17, 2016 at 08:07:48AM -0400, Michal Hocko wrote: [...] > > I liked your proposal when mem_cgroup_move_charge would be called from a > > context which doesn't hold the problematic rwsem much more. Would that > > be too

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-20 Thread Tejun Heo
Hello, Michal. On Sun, Apr 17, 2016 at 08:07:48AM -0400, Michal Hocko wrote: > On Fri 15-04-16 15:17:19, Tejun Heo wrote: > > mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec > > pages can be moved too. lru_add_drain_all() schedules and flushes > > work items on system_wq

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-20 Thread Tejun Heo
Hello, Michal. On Sun, Apr 17, 2016 at 08:07:48AM -0400, Michal Hocko wrote: > On Fri 15-04-16 15:17:19, Tejun Heo wrote: > > mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec > > pages can be moved too. lru_add_drain_all() schedules and flushes > > work items on system_wq

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-17 Thread Michal Hocko
On Fri 15-04-16 15:17:19, Tejun Heo wrote: > mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec > pages can be moved too. lru_add_drain_all() schedules and flushes > work items on system_wq which depends on being able to create new > kworkers to make forward progress. Since

Re: [PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-17 Thread Michal Hocko
On Fri 15-04-16 15:17:19, Tejun Heo wrote: > mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec > pages can be moved too. lru_add_drain_all() schedules and flushes > work items on system_wq which depends on being able to create new > kworkers to make forward progress. Since

[PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-15 Thread Tejun Heo
mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec pages can be moved too. lru_add_drain_all() schedules and flushes work items on system_wq which depends on being able to create new kworkers to make forward progress. Since 1ed1328792ff ("sched, cgroup: replace

[PATCH for-4.6-fixes] memcg: remove lru_add_drain_all() invocation from mem_cgroup_move_charge()

2016-04-15 Thread Tejun Heo
mem_cgroup_move_charge() invokes lru_add_drain_all() so that the pvec pages can be moved too. lru_add_drain_all() schedules and flushes work items on system_wq which depends on being able to create new kworkers to make forward progress. Since 1ed1328792ff ("sched, cgroup: replace