Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-04 Thread Mike Snitzer
On Mon, Nov 04 2013 at 12:49pm -0500, Mikulas Patocka wrote: > > > On Mon, 4 Nov 2013, Mike Snitzer wrote: > > > On Mon, Nov 04 2013 at 10:25am -0500, > > Mikulas Patocka wrote: > > > > > > > > > > > On Mon, 4 Nov 2013, Mike Snitzer wrote: > > > > > > > On Mon, Nov 04 2013 at 10:06am -050

Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-04 Thread Kent Overstreet
On Mon, Nov 04, 2013 at 10:06:00AM -0500, Mikulas Patocka wrote: > > > On Fri, 1 Nov 2013, Jens Axboe wrote: > > > On 11/01/2013 07:59 AM, Mike Snitzer wrote: > > > Add the missing bi_remaining increment, required by the block layer's > > > new bio-chaining code, to both the verity and old snaps

Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-04 Thread Mikulas Patocka
On Mon, 4 Nov 2013, Mike Snitzer wrote: > On Mon, Nov 04 2013 at 10:25am -0500, > Mikulas Patocka wrote: > > > > > > > On Mon, 4 Nov 2013, Mike Snitzer wrote: > > > > > On Mon, Nov 04 2013 at 10:06am -0500, > > > Mikulas Patocka wrote: > > > > > > > > The code uses atomic_inc for restorat

Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-04 Thread Mike Snitzer
On Mon, Nov 04 2013 at 10:25am -0500, Mikulas Patocka wrote: > > > On Mon, 4 Nov 2013, Mike Snitzer wrote: > > > On Mon, Nov 04 2013 at 10:06am -0500, > > Mikulas Patocka wrote: > > > > > > The code uses atomic_inc for restoration of bi_remaining. This patch > > > changes it to atomic_set(1)

Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-04 Thread Mikulas Patocka
On Mon, 4 Nov 2013, Mike Snitzer wrote: > On Mon, Nov 04 2013 at 10:06am -0500, > Mikulas Patocka wrote: > > > > > > > On Fri, 1 Nov 2013, Jens Axboe wrote: > > > > > On 11/01/2013 07:59 AM, Mike Snitzer wrote: > > > > Add the missing bi_remaining increment, required by the block layer's >

Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-04 Thread Mike Snitzer
On Mon, Nov 04 2013 at 10:06am -0500, Mikulas Patocka wrote: > > > On Fri, 1 Nov 2013, Jens Axboe wrote: > > > On 11/01/2013 07:59 AM, Mike Snitzer wrote: > > > Add the missing bi_remaining increment, required by the block layer's > > > new bio-chaining code, to both the verity and old snapsho

Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-04 Thread Mikulas Patocka
On Fri, 1 Nov 2013, Jens Axboe wrote: > On 11/01/2013 07:59 AM, Mike Snitzer wrote: > > Add the missing bi_remaining increment, required by the block layer's > > new bio-chaining code, to both the verity and old snapshot DM targets. > > > > Otherwise users will hit the bi_remaining <= 0 BUG_ON

Re: [PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-01 Thread Jens Axboe
On 11/01/2013 07:59 AM, Mike Snitzer wrote: > Add the missing bi_remaining increment, required by the block layer's > new bio-chaining code, to both the verity and old snapshot DM targets. > > Otherwise users will hit the bi_remaining <= 0 BUG_ON in bio_endio(). Thanks Mike, added to the mix. --

[PATCH for-next] dm: fix missing bi_remaining accounting

2013-11-01 Thread Mike Snitzer
Add the missing bi_remaining increment, required by the block layer's new bio-chaining code, to both the verity and old snapshot DM targets. Otherwise users will hit the bi_remaining <= 0 BUG_ON in bio_endio(). Signed-off-by: Mike Snitzer --- drivers/md/dm-snap.c |1 + drivers/md/dm-verit