Re: [PATCH for 3.12] mutex: Avoid gcc version dependent __builtin_constant_p() usage.

2013-10-17 Thread Peter Zijlstra
On Thu, Oct 17, 2013 at 12:54:21PM +0200, Maarten Lankhorst wrote: > op 17-10-13 12:52, Peter Zijlstra schreef: > > On Thu, Oct 17, 2013 at 07:45:29PM +0900, Tetsuo Handa wrote: > >> Commit 040a0a37 "mutex: Add support for wound/wait style locks" used > >> "!__builtin_constant_p(p == NULL)" but gcc

Re: [PATCH for 3.12] mutex: Avoid gcc version dependent __builtin_constant_p() usage.

2013-10-17 Thread Maarten Lankhorst
op 17-10-13 12:52, Peter Zijlstra schreef: > On Thu, Oct 17, 2013 at 07:45:29PM +0900, Tetsuo Handa wrote: >> Commit 040a0a37 "mutex: Add support for wound/wait style locks" used >> "!__builtin_constant_p(p == NULL)" but gcc 3.x cannot handle such expression >> correctly, leading to boot failure wh

Re: [PATCH for 3.12] mutex: Avoid gcc version dependent __builtin_constant_p() usage.

2013-10-17 Thread Peter Zijlstra
On Thu, Oct 17, 2013 at 07:45:29PM +0900, Tetsuo Handa wrote: > Commit 040a0a37 "mutex: Add support for wound/wait style locks" used > "!__builtin_constant_p(p == NULL)" but gcc 3.x cannot handle such expression > correctly, leading to boot failure when built with CONFIG_DEBUG_MUTEXES=y. So I comp

[PATCH for 3.12] mutex: Avoid gcc version dependent __builtin_constant_p() usage.

2013-10-17 Thread Tetsuo Handa
Commit 040a0a37 "mutex: Add support for wound/wait style locks" used "!__builtin_constant_p(p == NULL)" but gcc 3.x cannot handle such expression correctly, leading to boot failure when built with CONFIG_DEBUG_MUTEXES=y. Fix it by explicitly passing a bool which tells whether p != NULL or not. Si