Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-09-25 Thread Joonsoo Kim
2020년 9월 25일 (금) 오후 5:55, Vlastimil Babka 님이 작성: > > On 9/25/20 6:59 AM, Joonsoo Kim wrote: > > 2020년 8월 28일 (금) 오전 8:54, Joonsoo Kim 님이 작성: > > > > Hello, Andrew and Vlastimil. > > > > It's better to fix this possible bug introduced in v5.9-rc1 before > > v5.9 is released. > > Which approach do

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-09-25 Thread Vlastimil Babka
On 9/25/20 6:59 AM, Joonsoo Kim wrote: > 2020년 8월 28일 (금) 오전 8:54, Joonsoo Kim 님이 작성: > > Hello, Andrew and Vlastimil. > > It's better to fix this possible bug introduced in v5.9-rc1 before > v5.9 is released. > Which approach do you prefer? > If it is determined, I will immediately send a patch

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-09-24 Thread Joonsoo Kim
2020년 8월 28일 (금) 오전 8:54, Joonsoo Kim 님이 작성: > > 2020년 8월 27일 (목) 오후 10:35, Mel Gorman 님이 작성: > > > > On Wed, Aug 26, 2020 at 02:12:44PM +0900, Joonsoo Kim wrote: > > > > > And, it requires to break current code > > > > > layering that order-0 page is always handled by the pcplist. I'd > > > > >

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-27 Thread Joonsoo Kim
2020년 8월 27일 (목) 오후 10:35, Mel Gorman 님이 작성: > > On Wed, Aug 26, 2020 at 02:12:44PM +0900, Joonsoo Kim wrote: > > > > And, it requires to break current code > > > > layering that order-0 page is always handled by the pcplist. I'd prefer > > > > to avoid it so this patch uses different way to skip

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-27 Thread Mel Gorman
On Wed, Aug 26, 2020 at 02:12:44PM +0900, Joonsoo Kim wrote: > > > And, it requires to break current code > > > layering that order-0 page is always handled by the pcplist. I'd prefer > > > to avoid it so this patch uses different way to skip CMA page allocation > > > from the pcplist. > > > >

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-27 Thread Vlastimil Babka
On 8/26/20 7:12 AM, Joonsoo Kim wrote: > 2020년 8월 25일 (화) 오후 6:43, Vlastimil Babka 님이 작성: >> >> >> On 8/25/20 6:59 AM, js1...@gmail.com wrote: >> > From: Joonsoo Kim >> > >> > memalloc_nocma_{save/restore} APIs can be used to skip page allocation >> > on CMA area, but, there is a missing case and

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-25 Thread Joonsoo Kim
2020년 8월 26일 (수) 오전 9:42, Andrew Morton 님이 작성: > > On Tue, 25 Aug 2020 14:34:32 +0900 Joonsoo Kim wrote: > > > > > > > That's a bunch more code on a very hot path to serve an obscure feature > > > which has a single obscure callsite. > > > > > > Can we instead put the burden on that callsite

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-25 Thread Joonsoo Kim
2020년 8월 25일 (화) 오후 6:43, Vlastimil Babka 님이 작성: > > > On 8/25/20 6:59 AM, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > memalloc_nocma_{save/restore} APIs can be used to skip page allocation > > on CMA area, but, there is a missing case and the page on CMA area could > > be allocated

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-25 Thread Andrew Morton
On Tue, 25 Aug 2020 14:34:32 +0900 Joonsoo Kim wrote: > > > > That's a bunch more code on a very hot path to serve an obscure feature > > which has a single obscure callsite. > > > > Can we instead put the burden on that callsite rather than upon > > everyone? For (dumb) example, teach

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-25 Thread Vlastimil Babka
On 8/25/20 6:59 AM, js1...@gmail.com wrote: > From: Joonsoo Kim > > memalloc_nocma_{save/restore} APIs can be used to skip page allocation > on CMA area, but, there is a missing case and the page on CMA area could > be allocated even if APIs are used. This patch handles this case to fix > the

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-24 Thread Joonsoo Kim
2020년 8월 25일 (화) 오후 2:10, Andrew Morton 님이 작성: > > On Tue, 25 Aug 2020 13:59:42 +0900 js1...@gmail.com wrote: > > > From: Joonsoo Kim > > > > memalloc_nocma_{save/restore} APIs can be used to skip page allocation > > on CMA area, but, there is a missing case and the page on CMA area could > > be

Re: [PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-24 Thread Andrew Morton
On Tue, 25 Aug 2020 13:59:42 +0900 js1...@gmail.com wrote: > From: Joonsoo Kim > > memalloc_nocma_{save/restore} APIs can be used to skip page allocation > on CMA area, but, there is a missing case and the page on CMA area could > be allocated even if APIs are used. This patch handles this case

[PATCH for v5.9] mm/page_alloc: handle a missing case for memalloc_nocma_{save/restore} APIs

2020-08-24 Thread js1304
From: Joonsoo Kim memalloc_nocma_{save/restore} APIs can be used to skip page allocation on CMA area, but, there is a missing case and the page on CMA area could be allocated even if APIs are used. This patch handles this case to fix the potential issue. Missing case is an allocation from the