Re: Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-11 Thread Masami Hiramatsu
(2014/06/12 14:54), Namhyung Kim wrote: > On Thu, 12 Jun 2014 12:29:09 +0900, Masami Hiramatsu wrote: >> NO, ftrace_lookup_ip() returns NULL if the hash is empty, so adding >> !ftrace_hash_empty() is meaningless :) >> >> Actually, here I intended to have 3 meanings for the new/old_hash arguments, >

Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-11 Thread Masami Hiramatsu
(2014/06/12 14:38), Namhyung Kim wrote: > Hi Masami, > > On Thu, 12 Jun 2014 12:29:09 +0900, Masami Hiramatsu wrote: >> (2014/06/11 16:41), Namhyung Kim wrote: >>> Hi Masami, >>> >>> On Wed, 11 Jun 2014 10:28:01 +0900, Masami Hiramatsu wrote: (2014/06/10 22:53), Namhyung Kim wrote: > Hi M

Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-11 Thread Namhyung Kim
On Thu, 12 Jun 2014 12:29:09 +0900, Masami Hiramatsu wrote: > NO, ftrace_lookup_ip() returns NULL if the hash is empty, so adding > !ftrace_hash_empty() is meaningless :) > > Actually, here I intended to have 3 meanings for the new/old_hash arguments, > - If it is NULL, it hits all > - If it is EMP

Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-11 Thread Namhyung Kim
Hi Masami, On Thu, 12 Jun 2014 12:29:09 +0900, Masami Hiramatsu wrote: > (2014/06/11 16:41), Namhyung Kim wrote: >> Hi Masami, >> >> On Wed, 11 Jun 2014 10:28:01 +0900, Masami Hiramatsu wrote: >>> (2014/06/10 22:53), Namhyung Kim wrote: Hi Masami, 2014-06-10 (화), 10:50 +, Masam

Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-11 Thread Masami Hiramatsu
(2014/06/11 16:41), Namhyung Kim wrote: > Hi Masami, > > On Wed, 11 Jun 2014 10:28:01 +0900, Masami Hiramatsu wrote: >> (2014/06/10 22:53), Namhyung Kim wrote: >>> Hi Masami, >>> >>> 2014-06-10 (화), 10:50 +, Masami Hiramatsu: Introduce FTRACE_OPS_FL_IPMODIFY to avoid conflict among f

Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-11 Thread Namhyung Kim
Hi Masami, On Wed, 11 Jun 2014 10:28:01 +0900, Masami Hiramatsu wrote: > (2014/06/10 22:53), Namhyung Kim wrote: >> Hi Masami, >> >> 2014-06-10 (화), 10:50 +, Masami Hiramatsu: >>> Introduce FTRACE_OPS_FL_IPMODIFY to avoid conflict among >>> ftrace users who may modify regs->ip to change the e

Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-10 Thread Masami Hiramatsu
(2014/06/10 22:53), Namhyung Kim wrote: > Hi Masami, > > 2014-06-10 (화), 10:50 +, Masami Hiramatsu: >> Introduce FTRACE_OPS_FL_IPMODIFY to avoid conflict among >> ftrace users who may modify regs->ip to change the execution >> path. This also adds the flag to kprobe_ftrace_ops, since >> ftrace

Re: [PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-10 Thread Namhyung Kim
Hi Masami, 2014-06-10 (화), 10:50 +, Masami Hiramatsu: > Introduce FTRACE_OPS_FL_IPMODIFY to avoid conflict among > ftrace users who may modify regs->ip to change the execution > path. This also adds the flag to kprobe_ftrace_ops, since > ftrace-based kprobes already modifies regs->ip. Thus, if

[PATCH ftrace/core 2/2] ftrace, kprobes: Support IPMODIFY flag to find IP modify conflict

2014-06-10 Thread Masami Hiramatsu
Introduce FTRACE_OPS_FL_IPMODIFY to avoid conflict among ftrace users who may modify regs->ip to change the execution path. This also adds the flag to kprobe_ftrace_ops, since ftrace-based kprobes already modifies regs->ip. Thus, if another user modifies the regs->ip on the same function entry, one