Re: [PATCH leds v1 06/10] leds: pm8058: use struct led_init_data when registering

2020-09-17 Thread Marek Behun
On Wed, 16 Sep 2020 19:46:25 -0500 Bjorn Andersson wrote: > The pdev->dev -> dev and of_node changes are reasonable, but shouldn't > be part of this patch. It simply makes it hard to reason about he actual > change. > > Please respin this with only the introduction of led_init_data. > > Thanks,

Re: [PATCH leds v1 06/10] leds: pm8058: use struct led_init_data when registering

2020-09-16 Thread Bjorn Andersson
On Wed 16 Sep 18:16 CDT 2020, Marek Beh?n wrote: > By using struct led_init_data when registering we do not need to parse > `label` DT property nor `linux,default-trigger` property. > > Signed-off-by: Marek Behún > Cc: Linus Walleij > Cc: Bjorn Andersson > --- > drivers/leds/leds-pm8058.c | 3

[PATCH leds v1 06/10] leds: pm8058: use struct led_init_data when registering

2020-09-16 Thread Marek Behún
By using struct led_init_data when registering we do not need to parse `label` DT property nor `linux,default-trigger` property. Signed-off-by: Marek Behún Cc: Linus Walleij Cc: Bjorn Andersson --- drivers/leds/leds-pm8058.c | 38 +++--- 1 file changed, 19 inser