Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-08 Thread Jeff Garzik
On Mon, Aug 08, 2005 at 10:31:45AM -0700, Carlos Pardo wrote: > One question. Do the open source driver support pass-through commands ? if > so, how ? If you do not support it, are you planning to implement > pass-through commands sometime in the future ? I don't know about sata_sil24 in particu

RE: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-08 Thread Carlos Pardo
Jeff, et al - One question. Do the open source driver support pass-through commands ? if so, how ? If you do not support it, are you planning to implement pass-through commands sometime in the future ? Carlos - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-04 Thread Edward Falk
I agree that above code should clear both. Just wanna verify. Have you tested it and/or do you have any information confirming this? If we don't have any further info, I think we should read PORT_SLOT_STAT before clearing PORT_IRQ_STAT to be on the safe side. I've implemented the clear_irq

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-04 Thread Tejun Heo
Hi, again, Edward. Bad news... On Tue, Aug 02, 2005 at 03:56:05PM -0700, Edward Falk wrote: > > Again, you would need to fetch them from the returned FIS structure. > Here's a code fragment derived from SiI's issue_soft_reset() function: > > struct Port_Registers *port_base = yadayada;

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-03 Thread Tejun Heo
Hello, Edward. One more question. > > > > > >I think this will work (adapted from sil_interrupt(): > > > > > >static void sil_irq_clear(struct ata_port *ap) > > >{ > > >struct sil_port_priv *pp = ap->private_data; > > >struct Port_Registers *port_base = pp->pregs; > > >unsig

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-03 Thread Tejun Heo
Greetings, Edward and Jeff. Jeff, as my previous patchset against sil24 driver hasn't been accepted yet, and it seems that most of them can be done better with info from Edward, please ignore the patchset. I'll post a new patchset tomorrow (hopefully). Sorry about the hassle. On Wed, Aug 03,

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-02 Thread Jeff Garzik
Edward Falk wrote: Hi Tejun; I'm the guy at Google working on SATA drivers (port multipliers right now). As soon as I can (next week perhaps, I'll start looking at the driver you wrote. From what I can see, it looks quite good. + +static u8 sil24_check_status(struct ata_port *ap) +{ +

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-08-02 Thread Edward Falk
Hi Tejun; I'm the guy at Google working on SATA drivers (port multipliers right now). As soon as I can (next week perhaps, I'll start looking at the driver you wrote. From what I can see, it looks quite good. + +static u8 sil24_check_status(struct ata_port *ap) +{ + return ATA_DRDY;

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-07-30 Thread Tejun Heo
Hello, Jeff. I'll answer to your comments in this mail (and several questions, too) and will soon post patches fixing things in separate mails. On Thu, Jul 28, 2005 at 04:27:37PM -0400, Jeff Garzik wrote: > Tejun Heo wrote: > > Hello, Jeff. > > > > This is rewritten sil24 driver against v2.6.13

Re: [PATCH linux-2.6.13-rc3] SATA: rewritten sil24 driver

2005-07-28 Thread Jeff Garzik
Tejun Heo wrote: Hello, Jeff. This is rewritten sil24 driver against v2.6.13-rc3. It seems to work and am currently running stress test on it (random raw read of concurrency 4, repeatitive mount/copy/checksup/unmount). I'll keep running stress test for at least 12 hours and let you know if s