Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Markos Chandras
On 09/10/2014 10:05 AM, Ricardo Ribalda Delgado wrote: > Hello Markos > > Sorry for the mess. I have already send a new patch for mips using the > _IO* macros > > Just to put things a bit into context: > > I did made the patch for serial and tested it only in x86. I wrongly > infer that the IOCT

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Ricardo Ribalda Delgado
Hello Markos Sorry for the mess. I have already send a new patch for mips using the _IO* macros Just to put things a bit into context: I did made the patch for serial and tested it only in x86. I wrongly infer that the IOCTLS were defined for all the arches (sorry :S) Then when the patch was ap

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Markos Chandras
On 09/10/2014 09:39 AM, Ricardo Ribalda Delgado wrote: > Hello Greg > > Sorry, Probably my bad :). I did resend a new patch using the _IO* > macros, that has been now merged to tty-next > > Regards! > > On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras > wrote: >> On 09/09/2014 08:17 PM, Greg K

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Ricardo Ribalda Delgado
Hello Greg Sorry, Probably my bad :). I did resend a new patch using the _IO* macros, that has been now merged to tty-next Regards! On Wed, Sep 10, 2014 at 10:25 AM, Markos Chandras wrote: > On 09/09/2014 08:17 PM, Greg KH wrote: >> On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrot

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-10 Thread Markos Chandras
On 09/09/2014 08:17 PM, Greg KH wrote: > On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: >> Commit e676253b19b2d269cccf67fdb1592120a0cd0676 >> (serial/8250: Add support for RS485 IOCTLs) added cases for the >> TIOC{S,G}RS485 commands but this broke the build for MIPS: >> >> drivers

Re: [PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-09 Thread Greg KH
On Tue, Sep 09, 2014 at 12:52:55PM +0100, Markos Chandras wrote: > Commit e676253b19b2d269cccf67fdb1592120a0cd0676 > (serial/8250: Add support for RS485 IOCTLs) added cases for the > TIOC{S,G}RS485 commands but this broke the build for MIPS: > > drivers/tty/serial/8250/8250_core.c: In function 'se

[PATCH linux-next] MIPS: ioctls: Add missing TIOC{S,G}RS485 definitions

2014-09-09 Thread Markos Chandras
Commit e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add support for RS485 IOCTLs) added cases for the TIOC{S,G}RS485 commands but this broke the build for MIPS: drivers/tty/serial/8250/8250_core.c: In function 'serial8250_ioctl': drivers/tty/serial/8250/8250_core.c:2874:7: error: 'TIOCSR