Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-11-01 Thread Tim Gardner
On 11/01/2013 11:50 AM, Steve French wrote: > This has a couple of obvious endian errors. I will correct your patch > and remerge into cifs-2.6.git for-next > > Please always remember to run endian checks against cifs builds when > submitting a patch (and make sure sparse is installed) > > e.g.

Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-11-01 Thread Steve French
This has a couple of obvious endian errors. I will correct your patch and remerge into cifs-2.6.git for-next Please always remember to run endian checks against cifs builds when submitting a patch (and make sure sparse is installed) e.g. make C=1 M=fs/cifs modules CF=-D__CHECK_ENDIAN__ diff --

Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-10-28 Thread Steve French
merged into cifs-2.6.git for-next On Wed, Oct 16, 2013 at 3:03 PM, Jeff Layton wrote: > On Wed, 16 Oct 2013 10:32:42 -0600 > Tim Gardner wrote: > >> The multiplex identifier (MID) in the SMB header is only >> ever used by the client, in conjunction with PID, to match responses >> from the server

Re: [PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-10-16 Thread Jeff Layton
On Wed, 16 Oct 2013 10:32:42 -0600 Tim Gardner wrote: > The multiplex identifier (MID) in the SMB header is only > ever used by the client, in conjunction with PID, to match responses > from the server. As such, the endianess of the MID is not important. > However, When tracing packet sequences o

[PATCH linux-next V2] cifs: Make big endian multiplex ID sequences monotonic on the wire

2013-10-16 Thread Tim Gardner
The multiplex identifier (MID) in the SMB header is only ever used by the client, in conjunction with PID, to match responses from the server. As such, the endianess of the MID is not important. However, When tracing packet sequences on the wire, protocol analyzers such as wireshark display MID as