Re: [PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-15 Thread Honggang LI
On Wed, Apr 15, 2015 at 08:27:23AM +0300, Or Gerlitz wrote: > On 4/15/2015 6:19 AM, Honggang Li wrote: > >Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to firmware) > > This isn't the way to write the fix note, do it that way > > Fixes: bf0bf77f6519 ('mlx5: Support communicatin

Re: [PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Or Gerlitz
On 4/15/2015 6:19 AM, Honggang Li wrote: Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to firmware) This isn't the way to write the fix note, do it that way Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size to firmware') Signed-off-by: Honggang

Re: [PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Eli Cohen
Acked-by: Eli Cohen On Wed, Apr 15, 2015 at 11:19:17AM +0800, Honggang Li wrote: > If CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for x86 systems and physical > memory is more than 4GB, dma_map_page may return a valid memory > address which greater than 0x. As a result, the mlx5 device page > al

[PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Honggang Li
If CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for x86 systems and physical memory is more than 4GB, dma_map_page may return a valid memory address which greater than 0x. As a result, the mlx5 device page allocator RB tree will be initialized with valid addresses greater than 0xfff. However,