Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Balbir Singh
Hugh Dickins wrote: > On Tue, 18 Sep 2007, Balbir Singh wrote: >> Hugh Dickins wrote: >>> What would make sense is (what I meant when I said swap counted >>> along with RSS) not to count pages out and back in as they are >>> go out to swap and back in, just keep count of instantiated pages >>> >> I

Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Hugh Dickins
On Tue, 18 Sep 2007, Balbir Singh wrote: > Hugh Dickins wrote: > > > > What would make sense is (what I meant when I said swap counted > > along with RSS) not to count pages out and back in as they are > > go out to swap and back in, just keep count of instantiated pages > > > > I am not sure ho

Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Balbir Singh
Hugh Dickins wrote: > On Tue, 18 Sep 2007, Balbir Singh wrote: >> Hugh Dickins wrote: >>> More fundamentally, it looks like any container brought over its limit in >>> unuse_pte will abort swapoff: that doesn't doesn't seem "contained" to me. >>> Maybe unuse_pte should just let containers go over t

Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Balbir Singh
Hugh Dickins wrote: > rc4-mm1's memory-controller-memory-accounting-v7.patch broke swapoff: > it extended unuse_pte_range's boolean "found" return code to allow an > error return too; but ended up returning found (1) as an error. > Replace that by success (0) before it gets to the upper level. > >

Re: [PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Hugh Dickins
On Tue, 18 Sep 2007, Balbir Singh wrote: > Hugh Dickins wrote: > > More fundamentally, it looks like any container brought over its limit in > > unuse_pte will abort swapoff: that doesn't doesn't seem "contained" to me. > > Maybe unuse_pte should just let containers go over their limits without > >

[PATCH mm] fix swapoff breakage; however...

2007-09-17 Thread Hugh Dickins
rc4-mm1's memory-controller-memory-accounting-v7.patch broke swapoff: it extended unuse_pte_range's boolean "found" return code to allow an error return too; but ended up returning found (1) as an error. Replace that by success (0) before it gets to the upper level. Signed-off-by: Hugh Dickins <[E