Re: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-19 Thread Segher Boessenkool
On Thu, Mar 18, 2021 at 10:38:43AM +0100, Christophe Leroy wrote: > Yes it seems to be wrong. It was changed by commit d27dfd3887 ("Import > pre2.0.8"), so that's long time ago. Before that it was an 'int' for ppc32. > > gcc provides ptrdiff_t in stddef.h via __PTRDIFF_TYPE__ > gcc defined

Re: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-18 Thread Christophe Leroy
Le 18/03/2021 à 10:14, David Laight a écrit : From: Christophe Leroy Sent: 17 March 2021 17:35 Le 17/03/2021 à 13:51, David Laight a écrit : From: Christophe Leroy Sent: 16 March 2021 15:41 ... include/linux/types.h:typedef __kernel_ptrdiff_tptrdiff_t; And get: CC

RE: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-18 Thread David Laight
From: Christophe Leroy > Sent: 17 March 2021 17:35 > > Le 17/03/2021 à 13:51, David Laight a écrit : > > From: Christophe Leroy > >> Sent: 16 March 2021 15:41 > > ... > include/linux/types.h:typedef __kernel_ptrdiff_t ptrdiff_t; > > And get: > > CC

Re: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-17 Thread Christophe Leroy
Le 17/03/2021 à 13:51, David Laight a écrit : From: Christophe Leroy Sent: 16 March 2021 15:41 ... include/linux/types.h:typedef __kernel_ptrdiff_tptrdiff_t; And get: CC mm/kfence/report.o In file included from ./include/linux/printk.h:7, from

RE: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-17 Thread David Laight
From: Christophe Leroy > Sent: 16 March 2021 15:41 ... > >> include/linux/types.h:typedef __kernel_ptrdiff_t ptrdiff_t; > >> > >> And get: > >> > >>CC mm/kfence/report.o > >> In file included from ./include/linux/printk.h:7, > >> from ./include/linux/kernel.h:16, > >>

Re: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-16 Thread Christophe Leroy
Le 16/03/2021 à 16:33, Segher Boessenkool a écrit : On Tue, Mar 16, 2021 at 09:32:32AM +0100, Christophe Leroy wrote: +segher I cannot see through the wood of #defines here, sorry. Still a problem. I don't understand, gcc bug ? Rule #1: If you do not understand what is happening, it

Re: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-16 Thread Segher Boessenkool
On Tue, Mar 16, 2021 at 09:32:32AM +0100, Christophe Leroy wrote: > +segher I cannot see through the wood of #defines here, sorry. > Still a problem. > > I don't understand, gcc bug ? Rule #1: If you do not understand what is happening, it is not a compiler bug. I'm not saying that it isn't,

Re: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-16 Thread Christophe Leroy
+segher Le 03/03/2021 à 13:27, Alexander Potapenko a écrit : On Wed, Mar 3, 2021 at 1:12 PM Marco Elver wrote: Use %td for ptrdiff_t. Link: https://lkml.kernel.org/r/3abbe4c9-16ad-c168-a90f-087978ccd...@csgroup.eu Reported-by: Christophe Leroy Signed-off-by: Marco Elver Reviewed-by:

Re: [PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-03 Thread Alexander Potapenko
On Wed, Mar 3, 2021 at 1:12 PM Marco Elver wrote: > > Use %td for ptrdiff_t. > > Link: > https://lkml.kernel.org/r/3abbe4c9-16ad-c168-a90f-087978ccd...@csgroup.eu > Reported-by: Christophe Leroy > Signed-off-by: Marco Elver Reviewed-by: Alexander Potapenko

[PATCH mm] kfence: fix printk format for ptrdiff_t

2021-03-03 Thread Marco Elver
Use %td for ptrdiff_t. Link: https://lkml.kernel.org/r/3abbe4c9-16ad-c168-a90f-087978ccd...@csgroup.eu Reported-by: Christophe Leroy Signed-off-by: Marco Elver --- mm/kfence/report.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/mm/kfence/report.c