Re: [PATCH mm 1/2] kasan: don't use read-only static keys

2020-12-09 Thread Marco Elver
On Wed, 9 Dec 2020 at 19:57, Kees Cook wrote: > > On Wed, Dec 09, 2020 at 07:49:36PM +0100, Marco Elver wrote: > > On Wed, 9 Dec 2020 at 19:24, Andrey Konovalov wrote: > > > __ro_after_init static keys are incompatible with usage in loadable kernel > > > modules and cause crashes. Don't use

Re: [PATCH mm 1/2] kasan: don't use read-only static keys

2020-12-09 Thread Kees Cook
On Wed, Dec 09, 2020 at 07:49:36PM +0100, Marco Elver wrote: > On Wed, 9 Dec 2020 at 19:24, Andrey Konovalov wrote: > > __ro_after_init static keys are incompatible with usage in loadable kernel > > modules and cause crashes. Don't use those, use normal static keys. > > > > Signed-off-by: Andrey

Re: [PATCH mm 1/2] kasan: don't use read-only static keys

2020-12-09 Thread Marco Elver
On Wed, 9 Dec 2020 at 19:24, Andrey Konovalov wrote: > __ro_after_init static keys are incompatible with usage in loadable kernel > modules and cause crashes. Don't use those, use normal static keys. > > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > > This fix can be

[PATCH mm 1/2] kasan: don't use read-only static keys

2020-12-09 Thread Andrey Konovalov
__ro_after_init static keys are incompatible with usage in loadable kernel modules and cause crashes. Don't use those, use normal static keys. Signed-off-by: Andrey Konovalov --- This fix can be squashed into "kasan: add and integrate kasan boot parameters". --- mm/kasan/hw_tags.c | 4 ++--