Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Tue, 17 Nov 2020 10:55:21 +0800 you wrote: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to

Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-17 Thread Jakub Kicinski
On Tue, 17 Nov 2020 21:39:05 +0100 Marion & Christophe JAILLET wrote: > Le 17/11/2020 à 03:55, Zhang Changzhong a écrit : > > Fix to return a negative error code from the error handling > > case instead of 0, as done elsewhere in this function. > > > > Fixes: 85eb5bc33717 ("net: atheros: switch

Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-17 Thread Marion & Christophe JAILLET
Le 17/11/2020 à 03:55, Zhang Changzhong a écrit : Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API") Hi, should it have any importance, the Fixes tag is

Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-17 Thread Chris Snook
On Tue, Nov 17, 2020 at 1:01 AM Heiner Kallweit wrote: > > Am 17.11.2020 um 08:43 schrieb Chris Snook: > > The full text of the preceding comment explains the need: > > > > /* > > * The atl1c chip can DMA to 64-bit addresses, but it uses a single > > * shared register for the high 32 bits, so

Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-17 Thread Heiner Kallweit
Am 17.11.2020 um 08:43 schrieb Chris Snook: > The full text of the preceding comment explains the need: > > /* > * The atl1c chip can DMA to 64-bit addresses, but it uses a single > * shared register for the high 32 bits, so only a single, aligned, > * 4 GB physical address range can be used at a

Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-16 Thread Chris Snook
The full text of the preceding comment explains the need: /* * The atl1c chip can DMA to 64-bit addresses, but it uses a single * shared register for the high 32 bits, so only a single, aligned, * 4 GB physical address range can be used at a time. * * Supporting 64-bit DMA on this hardware is

Re: [PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-16 Thread Heiner Kallweit
Am 17.11.2020 um 03:55 schrieb Zhang Changzhong: > Fix to return a negative error code from the error handling > case instead of 0, as done elsewhere in this function. > > Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API") > Reported-by: Hulk Robot > Signed-off-by: Zhang

[PATCH net] atl1c: fix error return code in atl1c_probe()

2020-11-16 Thread Zhang Changzhong
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: 85eb5bc33717 ("net: atheros: switch from 'pci_' to 'dma_' API") Reported-by: Hulk Robot Signed-off-by: Zhang Changzhong --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c