Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

2015-12-08 Thread Kees Cook
On Wed, Dec 2, 2015 at 8:50 PM, David Miller wrote: > From: ebied...@xmission.com (Eric W. Biederman) > Date: Mon, 30 Nov 2015 15:38:15 -0600 > >> + if (dev_net(br->dev) == &init_net) > > Please respin this using net_eq() as Hannes pointed out. Sorry if I missed it: this this happen yet? -Ke

Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

2015-12-02 Thread David Miller
From: ebied...@xmission.com (Eric W. Biederman) Date: Mon, 30 Nov 2015 15:38:15 -0600 > + if (dev_net(br->dev) == &init_net) Please respin this using net_eq() as Hannes pointed out. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

2015-12-01 Thread Hannes Frederic Sowa
On Mon, Nov 30, 2015, at 22:38, Eric W. Biederman wrote: > Signed-off-by: "Eric W. Biederman" > --- > net/bridge/br_stp_if.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/net/bridge/br_stp_if.c b/net/bridge/br_stp_if.c > index 5396ff08af32..742fa89528ab 100644 > ---

Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

2015-11-30 Thread Richard Weinberger
Am 30.11.2015 um 22:38 schrieb Eric W. Biederman: > > There is no defined mechanism to pass network namespace information > into /sbin/bridge-stp therefore don't even try to invoke it except > for bridge devices in the initial network namespace. > > It is possible for unprivileged users to cause

Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

2015-11-30 Thread Eric W. Biederman
Stephen Hemminger writes: > On Mon, 30 Nov 2015 15:38:15 -0600 > ebied...@xmission.com (Eric W. Biederman) wrote: > >> >> There is no defined mechanism to pass network namespace information >> into /sbin/bridge-stp therefore don't even try to invoke it except >> for bridge devices in the initial

Re: [PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

2015-11-30 Thread Stephen Hemminger
On Mon, 30 Nov 2015 15:38:15 -0600 ebied...@xmission.com (Eric W. Biederman) wrote: > > There is no defined mechanism to pass network namespace information > into /sbin/bridge-stp therefore don't even try to invoke it except > for bridge devices in the initial network namespace. > > It is possib

[PATCH net] bridge: Only call /sbin/bridge-stp for the initial network namespace

2015-11-30 Thread Eric W. Biederman
There is no defined mechanism to pass network namespace information into /sbin/bridge-stp therefore don't even try to invoke it except for bridge devices in the initial network namespace. It is possible for unprivileged users to cause /sbin/bridge-stp to be invoked for any network device name whi