Re: [PATCH net] macvtap: fix tx_dropped counting error

2013-11-28 Thread David Miller
From: Jason Wang Date: Mon, 25 Nov 2013 17:19:04 +0800 > After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 > (macvlan: lockless tx path), tx stat counter were converted to percpu stat > structure. So we need use to this also for tx_dropped in macvtap. Otherwise, > the > management won't

Re: [PATCH net] macvtap: fix tx_dropped counting error

2013-11-28 Thread David Miller
From: Jason Wang jasow...@redhat.com Date: Mon, 25 Nov 2013 17:19:04 +0800 After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 (macvlan: lockless tx path), tx stat counter were converted to percpu stat structure. So we need use to this also for tx_dropped in macvtap. Otherwise, the

Re: [PATCH net] macvtap: fix tx_dropped counting error

2013-11-25 Thread Vlad Yasevich
On 11/25/2013 04:19 AM, Jason Wang wrote: > After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 > (macvlan: lockless tx path), tx stat counter were converted to percpu stat > structure. So we need use to this also for tx_dropped in macvtap. Otherwise, > the > management won't notice the

Re: [PATCH net] macvtap: fix tx_dropped counting error

2013-11-25 Thread Michael S. Tsirkin
On Mon, Nov 25, 2013 at 05:19:04PM +0800, Jason Wang wrote: > After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 > (macvlan: lockless tx path), tx stat counter were converted to percpu stat > structure. So we need use to this also for tx_dropped in macvtap. Otherwise, > the > management won't

[PATCH net] macvtap: fix tx_dropped counting error

2013-11-25 Thread Jason Wang
After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 (macvlan: lockless tx path), tx stat counter were converted to percpu stat structure. So we need use to this also for tx_dropped in macvtap. Otherwise, the management won't notice the dropping packet in macvtap tx path. Cc: Michael S. Tsirkin

[PATCH net] macvtap: fix tx_dropped counting error

2013-11-25 Thread Jason Wang
After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 (macvlan: lockless tx path), tx stat counter were converted to percpu stat structure. So we need use to this also for tx_dropped in macvtap. Otherwise, the management won't notice the dropping packet in macvtap tx path. Cc: Michael S. Tsirkin

Re: [PATCH net] macvtap: fix tx_dropped counting error

2013-11-25 Thread Michael S. Tsirkin
On Mon, Nov 25, 2013 at 05:19:04PM +0800, Jason Wang wrote: After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 (macvlan: lockless tx path), tx stat counter were converted to percpu stat structure. So we need use to this also for tx_dropped in macvtap. Otherwise, the management won't

Re: [PATCH net] macvtap: fix tx_dropped counting error

2013-11-25 Thread Vlad Yasevich
On 11/25/2013 04:19 AM, Jason Wang wrote: After commit 8ffab51b3dfc54876f145f15b351c41f3f703195 (macvlan: lockless tx path), tx stat counter were converted to percpu stat structure. So we need use to this also for tx_dropped in macvtap. Otherwise, the management won't notice the dropping