Re: [PATCH net] mvpp2: fix panic on module removal

2019-08-05 Thread David Miller
From: Matteo Croce Date: Mon, 5 Aug 2019 20:17:39 +0200 > On Mon, Aug 5, 2019 at 7:58 PM David Miller wrote: >> >> From: Matteo Croce >> Date: Wed, 31 Jul 2019 20:31:16 +0200 >> >> > mvpp2 uses a delayed workqueue to gather traffic statistics. >> > On module removal the workqueue can be destroy

Re: [PATCH net] mvpp2: fix panic on module removal

2019-08-05 Thread Matteo Croce
On Mon, Aug 5, 2019 at 7:58 PM David Miller wrote: > > From: Matteo Croce > Date: Wed, 31 Jul 2019 20:31:16 +0200 > > > mvpp2 uses a delayed workqueue to gather traffic statistics. > > On module removal the workqueue can be destroyed before calling > > cancel_delayed_work_sync() on its works. > >

Re: [PATCH net] mvpp2: fix panic on module removal

2019-08-05 Thread David Miller
From: Matteo Croce Date: Wed, 31 Jul 2019 20:31:16 +0200 > mvpp2 uses a delayed workqueue to gather traffic statistics. > On module removal the workqueue can be destroyed before calling > cancel_delayed_work_sync() on its works. > Fix it by moving the destroy_workqueue() call after mvpp2_port_rem

Re: [PATCH net] mvpp2: fix panic on module removal

2019-08-01 Thread Antoine Tenart
On Thu, Aug 01, 2019 at 01:46:39PM +0200, Matteo Croce wrote: > On Thu, Aug 1, 2019 at 9:18 AM Antoine Tenart > wrote: > > On Wed, Jul 31, 2019 at 08:31:16PM +0200, Matteo Croce wrote: > > > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > > b/drivers/net/ethernet/marvell/mv

Re: [PATCH net] mvpp2: fix panic on module removal

2019-08-01 Thread Matteo Croce
On Thu, Aug 1, 2019 at 9:18 AM Antoine Tenart wrote: > > Hi Matteo, > > On Wed, Jul 31, 2019 at 08:31:16PM +0200, Matteo Croce wrote: > > > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > > index c51f1d5b550b..5002d51fc9d6 100

Re: [PATCH net] mvpp2: fix panic on module removal

2019-08-01 Thread Antoine Tenart
Hi Matteo, On Wed, Jul 31, 2019 at 08:31:16PM +0200, Matteo Croce wrote: > > diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > index c51f1d5b550b..5002d51fc9d6 100644 > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/

[PATCH net] mvpp2: fix panic on module removal

2019-07-31 Thread Matteo Croce
mvpp2 uses a delayed workqueue to gather traffic statistics. On module removal the workqueue can be destroyed before calling cancel_delayed_work_sync() on its works. Fix it by moving the destroy_workqueue() call after mvpp2_port_remove(). # rmmod mvpp2 [ 2743.311722] mvpp2 f400.etherne