DSA network devices rely on having their DSA management interface up and
running otherwise their ndo_open() will return -ENETDOWN. Without doing
this it would not be possible to use DSA devices as netconsole when
configured on the command line. These devices also do not utilize the
upper/lower link
On Mon, Oct 19, 2020 at 10:17:44AM -0700, Florian Fainelli wrote:
> These devices also do not utilize the upper/lower linking so the
> check about the netpoll device having upper is not going to be a
> problem.
They do as of 2f1e8ea726e9 ("net: dsa: link interfaces with the DSA
master to get rid o
On 10/19/20 1:02 PM, Vladimir Oltean wrote:
> On Mon, Oct 19, 2020 at 10:17:44AM -0700, Florian Fainelli wrote:
>> These devices also do not utilize the upper/lower linking so the
>> check about the netpoll device having upper is not going to be a
>> problem.
>
> They do as of 2f1e8ea726e9 ("net:
On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote:
> > Completely crazy and outlandish idea, I know, but what's wrong with
> > doing this in DSA?
>
> I really do not have a problem with that approach however other stacked
> devices like 802.1Q do not do that. It certainly scales a l
On 10/20/20 6:12 PM, Jakub Kicinski wrote:
> On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote:
>> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote:
Completely crazy and outlandish idea, I know, but what's wrong with
doing this in DSA?
>>>
>>> I really do not have
On 11/16/20 3:06 PM, Florian Fainelli wrote:
> On 10/20/20 6:12 PM, Jakub Kicinski wrote:
>> On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote:
>>> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote:
> Completely crazy and outlandish idea, I know, but what's wrong with
On Mon, Nov 16, 2020 at 03:20:37PM -0800, Florian Fainelli wrote:
> I remember now there was a reason for me to "open code" this, and this
> is because since the patch is intended to be a bug fix, I wanted it to
> be independent from: 2f1e8ea726e9 ("net: dsa: link interfaces with the
> DSA master t
On Mon, 16 Nov 2020 15:20:37 -0800 Florian Fainelli wrote:
> >> Florian for you patch specifially - can't we use
> >> netdev_for_each_lower_dev()?
> >
> > Looks like I forgot to respond here, yes we could do that because we do
> > call netdev_upper_dev_link() in net/dsa/slave.c. Let me re-post w
On Mon, Nov 16, 2020 at 03:47:10PM -0800, Jakub Kicinski wrote:
> On Mon, 16 Nov 2020 15:20:37 -0800 Florian Fainelli wrote:
> > >> Florian for you patch specifially - can't we use
> > >> netdev_for_each_lower_dev()?
> > >
> > > Looks like I forgot to respond here, yes we could do that because w
On Tue, 17 Nov 2020 01:54:05 +0200 Vladimir Oltean wrote:
> Yeah, I think Florian just wants netconsole to work in stable kernels,
> which is a fair point. As for my 16-line patch that I suggested to him
> in the initial reply, what do you think, would that be a "stable"
> candidate? We would be in
On Mon, Nov 16, 2020 at 04:04:49PM -0800, Jakub Kicinski wrote:
> On Tue, 17 Nov 2020 01:54:05 +0200 Vladimir Oltean wrote:
> > Yeah, I think Florian just wants netconsole to work in stable kernels,
> > which is a fair point. As for my 16-line patch that I suggested to him
> > in the initial reply,
On 11/16/20 4:12 PM, Vladimir Oltean wrote:
> On Mon, Nov 16, 2020 at 04:04:49PM -0800, Jakub Kicinski wrote:
>> On Tue, 17 Nov 2020 01:54:05 +0200 Vladimir Oltean wrote:
>>> Yeah, I think Florian just wants netconsole to work in stable kernels,
>>> which is a fair point. As for my 16-line patch th
On Mon, Oct 19, 2020 at 10:17:44AM -0700, Florian Fainelli wrote:
> DSA network devices rely on having their DSA management interface up and
> running otherwise their ndo_open() will return -ENETDOWN. Without doing
> this it would not be possible to use DSA devices as netconsole when
> configured o
On Tue, 20 Oct 2020 00:19:16 +0300 Vladimir Oltean wrote:
> On Mon, Oct 19, 2020 at 02:03:40PM -0700, Florian Fainelli wrote:
> > > Completely crazy and outlandish idea, I know, but what's wrong with
> > > doing this in DSA?
> >
> > I really do not have a problem with that approach however other
14 matches
Mail list logo