Re: [PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-06 Thread David Miller
From: Florian Fainelli Date: Mon, 4 May 2020 13:18:06 -0700 > When ndo_get_phys_port_name() for the CPU port was added we introduced > an early check for when the DSA master network device in > dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When > we perform the teardown

Re: [PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-05 Thread Allen
When ndo_get_phys_port_name() for the CPU port was added we introduced an early check for when the DSA master network device in dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When we perform the teardown operation in dsa_master_ndo_teardown() we would not be checking that

Re: [PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-04 Thread Florian Fainelli
On 5/4/2020 1:49 PM, Vladimir Oltean wrote: > On Mon, 4 May 2020 at 23:40, Florian Fainelli wrote: >> >> >> >> On 5/4/2020 1:34 PM, Vladimir Oltean wrote: >>> Hi Florian, >>> >>> On Mon, 4 May 2020 at 23:19, Florian Fainelli wrote: When ndo_get_phys_port_name() for the CPU port was

Re: [PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-04 Thread Vladimir Oltean
On Mon, 4 May 2020 at 23:40, Florian Fainelli wrote: > > > > On 5/4/2020 1:34 PM, Vladimir Oltean wrote: > > Hi Florian, > > > > On Mon, 4 May 2020 at 23:19, Florian Fainelli wrote: > >> > >> When ndo_get_phys_port_name() for the CPU port was added we introduced > >> an early check for when the

Re: [PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-04 Thread Florian Fainelli
On 5/4/2020 1:34 PM, Vladimir Oltean wrote: > Hi Florian, > > On Mon, 4 May 2020 at 23:19, Florian Fainelli wrote: >> >> When ndo_get_phys_port_name() for the CPU port was added we introduced >> an early check for when the DSA master network device in >> dsa_master_ndo_setup() already

Re: [PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-04 Thread Vladimir Oltean
Hi Florian, On Mon, 4 May 2020 at 23:19, Florian Fainelli wrote: > > When ndo_get_phys_port_name() for the CPU port was added we introduced > an early check for when the DSA master network device in > dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When > we perform the

[PATCH net] net: dsa: Do not leave DSA master with NULL netdev_ops

2020-05-04 Thread Florian Fainelli
When ndo_get_phys_port_name() for the CPU port was added we introduced an early check for when the DSA master network device in dsa_master_ndo_setup() already implements ndo_get_phys_port_name(). When we perform the teardown operation in dsa_master_ndo_teardown() we would not be checking that