Re: [PATCH net] net: ipv4: do not handle duplicate fragments as overlapping

2018-12-13 Thread Michal Kubecek
On Wed, Dec 12, 2018 at 10:20:42PM -0800, Eric Dumazet wrote: > On 12/12/2018 06:28 PM, Michal Kubecek wrote: > > Since commit 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping > > segments.") IPv4 reassembly code drops the whole queue whenever an > > overlapping fragment is received.

Re: [PATCH net] net: ipv4: do not handle duplicate fragments as overlapping

2018-12-12 Thread Eric Dumazet
On 12/12/2018 06:28 PM, Michal Kubecek wrote: > Since commit 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping > segments.") IPv4 reassembly code drops the whole queue whenever an > overlapping fragment is received. However, the test is written in a way > which detects duplicate

Re: [PATCH net] net: ipv4: do not handle duplicate fragments as overlapping

2018-12-12 Thread David Miller
From: Michal Kubecek Date: Thu, 13 Dec 2018 03:28:00 +0100 (CET) > Since commit 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping > segments.") IPv4 reassembly code drops the whole queue whenever an > overlapping fragment is received. However, the test is written in a way > which

[PATCH net] net: ipv4: do not handle duplicate fragments as overlapping

2018-12-12 Thread Michal Kubecek
Since commit 7969e5c40dfd ("ip: discard IPv4 datagrams with overlapping segments.") IPv4 reassembly code drops the whole queue whenever an overlapping fragment is received. However, the test is written in a way which detects duplicate fragments as overlapping so that in environments with many