Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-23 Thread David Miller
From: Florian Fainelli Date: Tue, 22 May 2018 17:04:49 -0700 > On newer PHYs, we need to select the expansion register to write with > setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior > to being migrated to generic code under bcm-phy-lib.c which >

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-23 Thread David Miller
From: Florian Fainelli Date: Tue, 22 May 2018 17:04:49 -0700 > On newer PHYs, we need to select the expansion register to write with > setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior > to being migrated to generic code under bcm-phy-lib.c which > unfortunately used the

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-23 Thread Florian Fainelli
On 05/22/2018 06:20 PM, Florian Fainelli wrote: > Hi Andrew, > > On 05/22/2018 05:15 PM, Andrew Lunn wrote: >> On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: >>> On newer PHYs, we need to select the expansion register to write with >>> setting bits [11:8] to 0xf. This was done

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-23 Thread Florian Fainelli
On 05/22/2018 06:20 PM, Florian Fainelli wrote: > Hi Andrew, > > On 05/22/2018 05:15 PM, Andrew Lunn wrote: >> On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: >>> On newer PHYs, we need to select the expansion register to write with >>> setting bits [11:8] to 0xf. This was done

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Florian Fainelli
Hi Andrew, On 05/22/2018 05:15 PM, Andrew Lunn wrote: > On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: >> On newer PHYs, we need to select the expansion register to write with >> setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior >> to being migrated to

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Florian Fainelli
Hi Andrew, On 05/22/2018 05:15 PM, Andrew Lunn wrote: > On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: >> On newer PHYs, we need to select the expansion register to write with >> setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior >> to being migrated to

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Andrew Lunn
On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: > On newer PHYs, we need to select the expansion register to write with > setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior > to being migrated to generic code under bcm-phy-lib.c which > unfortunately used the

Re: [PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Andrew Lunn
On Tue, May 22, 2018 at 05:04:49PM -0700, Florian Fainelli wrote: > On newer PHYs, we need to select the expansion register to write with > setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior > to being migrated to generic code under bcm-phy-lib.c which > unfortunately used the

[PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Florian Fainelli
On newer PHYs, we need to select the expansion register to write with setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior to being migrated to generic code under bcm-phy-lib.c which unfortunately used the older implementation from the BCM54xx days. Fix this by creating an

[PATCH net] net: phy: broadcom: Fix bcm_write_exp()

2018-05-22 Thread Florian Fainelli
On newer PHYs, we need to select the expansion register to write with setting bits [11:8] to 0xf. This was done correctly by bcm7xxx.c prior to being migrated to generic code under bcm-phy-lib.c which unfortunately used the older implementation from the BCM54xx days. Fix this by creating an