Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-22 Thread Eyal Birger
Hi, On Mon, 21 Oct 2019 13:50:13 -0700 Cong Wang wrote: > On Fri, Oct 18, 2019 at 2:25 PM Eyal Birger > wrote: > > > > Hi, > > > > On Fri, 18 Oct 2019 00:33:53 +0800 > > Zhiyuan Hou wrote: > > > > > On 2019/10/16 8:13 下午, Eyal Birger wrote: > > > > Hi, > > > > > > > > On Wed, 16 Oct 2019

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-21 Thread Cong Wang
On Fri, Oct 18, 2019 at 2:25 PM Eyal Birger wrote: > > Hi, > > On Fri, 18 Oct 2019 00:33:53 +0800 > Zhiyuan Hou wrote: > > > On 2019/10/16 8:13 下午, Eyal Birger wrote: > > > Hi, > > > > > > On Wed, 16 Oct 2019 01:22:01 +0800 > > > Zhiyuan Hou wrote: > > > > > >> On 2019/10/15 1:57 上午, Cong Wang

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-21 Thread Zhiyuan Hou
On 2019/10/19 5:25 上午, Eyal Birger wrote: Hi, On Fri, 18 Oct 2019 00:33:53 +0800 Zhiyuan Hou wrote: On 2019/10/16 8:13 下午, Eyal Birger wrote: Hi, On Wed, 16 Oct 2019 01:22:01 +0800 Zhiyuan Hou wrote: On 2019/10/15 1:57 上午, Cong Wang wrote: On Sat, Oct 12, 2019 at 12:16 AM Zhiyuan

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-18 Thread Eyal Birger
Hi, On Fri, 18 Oct 2019 00:33:53 +0800 Zhiyuan Hou wrote: > On 2019/10/16 8:13 下午, Eyal Birger wrote: > > Hi, > > > > On Wed, 16 Oct 2019 01:22:01 +0800 > > Zhiyuan Hou wrote: > > > >> On 2019/10/15 1:57 上午, Cong Wang wrote: > >>> On Sat, Oct 12, 2019 at 12:16 AM Zhiyuan Hou > >>> wrote:

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-17 Thread Zhiyuan Hou
On 2019/10/16 8:13 下午, Eyal Birger wrote: Hi, On Wed, 16 Oct 2019 01:22:01 +0800 Zhiyuan Hou wrote: On 2019/10/15 1:57 上午, Cong Wang wrote: On Sat, Oct 12, 2019 at 12:16 AM Zhiyuan Hou wrote: diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c index 9ce073a05414..6108a64c0cd5

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-17 Thread Zhiyuan Hou
On 2019/10/14 8:46 下午, Eric Dumazet wrote: On 10/14/19 12:07 AM, Zhiyuan Hou wrote: On 2019/10/12 6:59 下午, Eric Dumazet wrote: On 10/12/19 12:16 AM, Zhiyuan Hou wrote: In act_mirred's ingress redirection, if the skb's dst_entry is valid when call function netif_receive_skb, the fllowing l3

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-16 Thread Eyal Birger
Hi, On Wed, 16 Oct 2019 01:22:01 +0800 Zhiyuan Hou wrote: > On 2019/10/15 1:57 上午, Cong Wang wrote: > > On Sat, Oct 12, 2019 at 12:16 AM Zhiyuan Hou > > wrote: > >> diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c > >> index 9ce073a05414..6108a64c0cd5 100644 > >> ---

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-15 Thread Zhiyuan Hou
On 2019/10/15 1:57 上午, Cong Wang wrote: On Sat, Oct 12, 2019 at 12:16 AM Zhiyuan Hou wrote: diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c index 9ce073a05414..6108a64c0cd5 100644 --- a/net/sched/act_mirred.c +++ b/net/sched/act_mirred.c @@ -18,6 +18,7 @@ #include #include

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-14 Thread Cong Wang
On Sat, Oct 12, 2019 at 12:16 AM Zhiyuan Hou wrote: > diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c > index 9ce073a05414..6108a64c0cd5 100644 > --- a/net/sched/act_mirred.c > +++ b/net/sched/act_mirred.c > @@ -18,6 +18,7 @@ > #include > #include > #include > +#include >

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-14 Thread Eric Dumazet
On 10/14/19 12:07 AM, Zhiyuan Hou wrote: > > On 2019/10/12 6:59 下午, Eric Dumazet wrote: >> >> On 10/12/19 12:16 AM, Zhiyuan Hou wrote: >>> In act_mirred's ingress redirection, if the skb's dst_entry is valid >>> when call function netif_receive_skb, the fllowing l3 stack process >>>

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-14 Thread Zhiyuan Hou
On 2019/10/13 3:34 上午, Sergei Shtylyov wrote: Hello! On 10/12/2019 10:16 AM, Zhiyuan Hou wrote: In act_mirred's ingress redirection, if the skb's dst_entry is valid when call function netif_receive_skb, the fllowing l3 stack process Following or flowing? Sorry, it should be following.

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-14 Thread Zhiyuan Hou
On 2019/10/12 6:59 下午, Eric Dumazet wrote: On 10/12/19 12:16 AM, Zhiyuan Hou wrote: In act_mirred's ingress redirection, if the skb's dst_entry is valid when call function netif_receive_skb, the fllowing l3 stack process (ip_rcv_finish_core) will check dst_entry and skip the routing

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-12 Thread Sergei Shtylyov
Hello! On 10/12/2019 10:16 AM, Zhiyuan Hou wrote: > In act_mirred's ingress redirection, if the skb's dst_entry is valid > when call function netif_receive_skb, the fllowing l3 stack process Following or flowing? > (ip_rcv_finish_core) will check dst_entry and skip the routing > decision.

Re: [PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-12 Thread Eric Dumazet
On 10/12/19 12:16 AM, Zhiyuan Hou wrote: > In act_mirred's ingress redirection, if the skb's dst_entry is valid > when call function netif_receive_skb, the fllowing l3 stack process > (ip_rcv_finish_core) will check dst_entry and skip the routing > decision. Using the old dst_entry is

[PATCH net] net: sched: act_mirred: drop skb's dst_entry in ingress redirection

2019-10-12 Thread Zhiyuan Hou
In act_mirred's ingress redirection, if the skb's dst_entry is valid when call function netif_receive_skb, the fllowing l3 stack process (ip_rcv_finish_core) will check dst_entry and skip the routing decision. Using the old dst_entry is unexpected and may discard the skb in some case. For example