Re: [PATCH net] net: sched: do not requeue a NULL skb

2016-04-06 Thread Cong Wang
On Wed, Apr 6, 2016 at 6:10 AM, Lars Persson wrote: > A failure in validate_xmit_skb_list() triggered an unconditional call > to dev_requeue_skb with skb=NULL. This slowly grows the queue > discipline's qlen count until all traffic through the queue stops. > Sounds reasonable. > Fixes: 55a93b3ea

[PATCH net] net: sched: do not requeue a NULL skb

2016-04-06 Thread Lars Persson
A failure in validate_xmit_skb_list() triggered an unconditional call to dev_requeue_skb with skb=NULL. This slowly grows the queue discipline's qlen count until all traffic through the queue stops. Fixes: 55a93b3ea780 ("qdisc: validate skb without holding lock") Signed-off-by: Lars Persson ---