Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

2021-01-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 29 Jan 2021 23:53:50 + you wrote: > AF_RXRPC sockets use UDP ports in encap mode. This causes socket and dst > from an incoming packet to get stolen and attached to the UDP socket from > whence it is leaked when

[PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

2021-01-29 Thread David Howells
AF_RXRPC sockets use UDP ports in encap mode. This causes socket and dst from an incoming packet to get stolen and attached to the UDP socket from whence it is leaked when that socket is closed. When a network namespace is removed, the wait for dst records to be cleaned up happens before the

Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

2021-01-29 Thread Vadim Fedorenko
On 29.01.2021 17:41, David Howells wrote: Vadim Fedorenko wrote: You missed the call to dst_release(sk->sk_rx_dst) in rxrpc_sock_destructor. Without it we are still leaking the dst. Hmmm... I no longer get the messages appearing with this patch. I'll have another look. Sorry, my bad.

Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

2021-01-29 Thread David Howells
Vadim Fedorenko wrote: > You missed the call to dst_release(sk->sk_rx_dst) in > rxrpc_sock_destructor. Without it we are still leaking the dst. Hmmm... I no longer get the messages appearing with this patch. I'll have another look. David

Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

2021-01-29 Thread Vadim Fedorenko
On 29.01.2021 17:30, Vadim Fedorenko wrote: On 29.01.2021 16:44, David Howells wrote: AF_RXRPC sockets use UDP ports in encap mode.  This causes socket and dst from an incoming packet to get stolen and attached to the UDP socket from whence it is leaked when that socket is closed. When a

Re: [PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

2021-01-29 Thread Vadim Fedorenko
On 29.01.2021 16:44, David Howells wrote: AF_RXRPC sockets use UDP ports in encap mode. This causes socket and dst from an incoming packet to get stolen and attached to the UDP socket from whence it is leaked when that socket is closed. When a network namespace is removed, the wait for dst

[PATCH net] rxrpc: Fix deadlock around release of dst cached on udp tunnel

2021-01-29 Thread David Howells
AF_RXRPC sockets use UDP ports in encap mode. This causes socket and dst from an incoming packet to get stolen and attached to the UDP socket from whence it is leaked when that socket is closed. When a network namespace is removed, the wait for dst records to be cleaned up happens before the