Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-10 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 6 Sep 2024 17:07:43 -0400 you wrote: > Padding is not included in UDP and TCP checksums. Therefore, reduce the > length of the checksummed data to include only the data in the IP > payload. This fixes spurious rep

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-10 Thread Willem de Bruijn
Sean Anderson wrote: > On 9/10/24 13:42, Willem de Bruijn wrote: > > Sean Anderson wrote: > >> On 9/9/24 21:01, Willem de Bruijn wrote: > >> > Jakub Kicinski wrote: > >> >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: > >> >> > > This seems to be a bug in the driver. > >> >> > > > >>

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-10 Thread Sean Anderson
On 9/10/24 13:42, Willem de Bruijn wrote: > Sean Anderson wrote: >> On 9/9/24 21:01, Willem de Bruijn wrote: >> > Jakub Kicinski wrote: >> >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: >> >> > > This seems to be a bug in the driver. >> >> > > >> >> > > A call to skb_put_padto(skb,

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-10 Thread Willem de Bruijn
Sean Anderson wrote: > On 9/9/24 21:01, Willem de Bruijn wrote: > > Jakub Kicinski wrote: > >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: > >> > > This seems to be a bug in the driver. > >> > > > >> > > A call to skb_put_padto(skb, ETH_ZLEN) should be added. > >> > > >> > In whi

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-10 Thread Sean Anderson
On 9/9/24 21:01, Willem de Bruijn wrote: > Jakub Kicinski wrote: >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: >> > > This seems to be a bug in the driver. >> > > >> > > A call to skb_put_padto(skb, ETH_ZLEN) should be added. >> > >> > In which case this test detecting it may be

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Willem de Bruijn
Jakub Kicinski wrote: > On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: > > > This seems to be a bug in the driver. > > > > > > A call to skb_put_padto(skb, ETH_ZLEN) should be added. > > > > In which case this test detecting it may be nice to have, for lack of > > a more targeted te

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Jakub Kicinski
On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: > > This seems to be a bug in the driver. > > > > A call to skb_put_padto(skb, ETH_ZLEN) should be added. > > In which case this test detecting it may be nice to have, for lack of > a more targeted test. IIUC we're basically saying tha

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Willem de Bruijn
Eric Dumazet wrote: > On Mon, Sep 9, 2024 at 5:02 PM Sean Anderson wrote: > > > > On 9/6/24 22:05, Willem de Bruijn wrote: > > > Sean Anderson wrote: > > >> Padding is not included in UDP and TCP checksums. Therefore, reduce the > > >> length of the checksummed data to include only the data in the

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Eric Dumazet
On Mon, Sep 9, 2024 at 5:02 PM Sean Anderson wrote: > > On 9/6/24 22:05, Willem de Bruijn wrote: > > Sean Anderson wrote: > >> Padding is not included in UDP and TCP checksums. Therefore, reduce the > >> length of the checksummed data to include only the data in the IP > >> payload. This fixes spu

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Willem de Bruijn
Sean Anderson wrote: > On 9/6/24 22:05, Willem de Bruijn wrote: > > Sean Anderson wrote: > >> Padding is not included in UDP and TCP checksums. Therefore, reduce the > >> length of the checksummed data to include only the data in the IP > >> payload. This fixes spurious reported checksum failures l

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Sean Anderson
On 9/6/24 22:05, Willem de Bruijn wrote: > Sean Anderson wrote: >> Padding is not included in UDP and TCP checksums. Therefore, reduce the >> length of the checksummed data to include only the data in the IP >> payload. This fixes spurious reported checksum failures like >> >> rx: pkt: sport=33000

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-06 Thread Willem de Bruijn
Sean Anderson wrote: > Padding is not included in UDP and TCP checksums. Therefore, reduce the > length of the checksummed data to include only the data in the IP > payload. This fixes spurious reported checksum failures like > > rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe > pkt: bad csu

[PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-06 Thread Sean Anderson
Padding is not included in UDP and TCP checksums. Therefore, reduce the length of the checksummed data to include only the data in the IP payload. This fixes spurious reported checksum failures like rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe pkt: bad csum Technically it is possible for