Re: [PATCH net] virtio-net: validate features during probe

2014-11-19 Thread Jason Wang
On 11/19/2014 05:39 PM, Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 05:33:26PM +0800, Jason Wang wrote: >> On 11/19/2014 04:59 PM, Michael S. Tsirkin wrote: >>> On Wed, Nov 19, 2014 at 02:35:39PM +0800, Jason Wang wrote: This patch validates feature dependencies during probe and fail t

Re: [PATCH net] virtio-net: validate features during probe

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 05:33:26PM +0800, Jason Wang wrote: > On 11/19/2014 04:59 PM, Michael S. Tsirkin wrote: > > On Wed, Nov 19, 2014 at 02:35:39PM +0800, Jason Wang wrote: > >> This patch validates feature dependencies during probe and fail the probing > >> if a dependency is missed. This fixes

Re: [PATCH net] virtio-net: validate features during probe

2014-11-19 Thread Jason Wang
On 11/19/2014 04:59 PM, Michael S. Tsirkin wrote: > On Wed, Nov 19, 2014 at 02:35:39PM +0800, Jason Wang wrote: >> This patch validates feature dependencies during probe and fail the probing >> if a dependency is missed. This fixes the issues of hitting BUG() >> when qemu fails to advertise feature

Re: [PATCH net] virtio-net: validate features during probe

2014-11-19 Thread Cornelia Huck
On Wed, 19 Nov 2014 10:59:39 +0200 "Michael S. Tsirkin" wrote: > +bool __virtnet_fail_on_feature(struct virtio_device *vdev, unsigned int fbit, > +const char *fname) > +{ > + if (!virtio_has_feature(vdev, fbit)) > + return false; > + > +dev_err

Re: [PATCH net] virtio-net: validate features during probe

2014-11-19 Thread Michael S. Tsirkin
On Wed, Nov 19, 2014 at 02:35:39PM +0800, Jason Wang wrote: > This patch validates feature dependencies during probe and fail the probing > if a dependency is missed. This fixes the issues of hitting BUG() > when qemu fails to advertise features correctly. One example is booting > guest with ctrl_v

Re: [PATCH net] virtio-net: validate features during probe

2014-11-18 Thread Jason Wang
On 11/19/2014 02:35 PM, Jason Wang wrote: > This patch validates feature dependencies during probe and fail the probing > if a dependency is missed. This fixes the issues of hitting BUG() > when qemu fails to advertise features correctly. One example is booting > guest with ctrl_vq=off through qemu

[PATCH net] virtio-net: validate features during probe

2014-11-18 Thread Jason Wang
This patch validates feature dependencies during probe and fail the probing if a dependency is missed. This fixes the issues of hitting BUG() when qemu fails to advertise features correctly. One example is booting guest with ctrl_vq=off through qemu. Cc: Rusty Russell Cc: Michael S. Tsirkin Cc: