Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Iyappan Subramanian
On Fri, Jul 28, 2017 at 7:23 AM, Tom Bogendoerfer wrote: > On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: >> I don't know the intricacies of the Mustang hardware but external >> aborts have been a symptom of missing clocks on other hardware. > > you are right, it's a missing clock.

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Laura Abbott
On 07/28/2017 07:23 AM, Tom Bogendoerfer wrote: > On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: >> I don't know the intricacies of the Mustang hardware but external >> aborts have been a symptom of missing clocks on other hardware. > > you are right, it's a missing clock. For SGMII

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 03:39:58PM -0700, Laura Abbott wrote: > I don't know the intricacies of the Mustang hardware but external > aborts have been a symptom of missing clocks on other hardware. you are right, it's a missing clock. For SGMII ports the driver doesn't really use the clock source ot

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Laura Abbott
On 07/27/2017 02:39 PM, Tom Bogendoerfer wrote: > On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: >> This change causes boot failures for me on my APM Mustang system running >> Fedora rawhide: >> >> [ 16.669089] Synchronous External Abort: synchronous external abort >> (0x960 >

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Tom Bogendoerfer
On Thu, Jul 27, 2017 at 02:03:42PM -0700, Laura Abbott wrote: > This change causes boot failures for me on my APM Mustang system running > Fedora rawhide: > > [ 16.669089] Synchronous External Abort: synchronous external abort > (0x960 > [ 16.669099] Internal error: : 9610 [#1] SMP

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-27 Thread Laura Abbott
On 07/13/2017 01:57 AM, Thomas Bogendoerfer wrote: > From: Thomas Bogendoerfer > > This change fixes following problem > > [1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2 > > which leads to a missing ethernet interface (reproducable at least on > Gigabyte MP30-AR0 and

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-13 Thread David Miller
From: Thomas Bogendoerfer Date: Thu, 13 Jul 2017 10:57:40 +0200 > From: Thomas Bogendoerfer > > This change fixes following problem > > [1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2 > > which leads to a missing ethernet interface (reproducable at least on > Gigaby

[PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-13 Thread Thomas Bogendoerfer
From: Thomas Bogendoerfer This change fixes following problem [1.827940] xgene-enet: probe of 1f210030.ethernet failed with error -2 which leads to a missing ethernet interface (reproducable at least on Gigabyte MP30-AR0 and APM Mustang systems). The check for a valid clk resource fails, b