Re: [PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-25 Thread David Miller
From: six...@microsoft.com Date: Fri, 24 Apr 2015 11:34:48 -0700 > + net_device_ctx->msg_enable = netif_msg_init(debug, default_msg); > + if (netif_msg_probe(net_device_ctx)) > + netdev_dbg(net, "netvsc msg_enable: %d", > +net_device_ctx->msg_enable); >

Re: [PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-24 Thread Joe Perches
On Fri, 2015-04-24 at 22:52 +, Simon Xiao wrote: > > From: Joe Perches [mailto:j...@perches.com] > > On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote: > > > From: Simon Xiao > > > > > > 1. Introduce netif-msg to netvsc to control debug logging output and > > > keep msg_enable in n

RE: [PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-24 Thread Simon Xiao
PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into > netvsc module > > On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote: > > From: Simon Xiao > > > > 1. Introduce netif-msg to netvsc to control debug logging output and > > keep msg_enable in netvsc_dev

Re: [PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-24 Thread Joe Perches
On Fri, 2015-04-24 at 11:34 -0700, six...@microsoft.com wrote: > From: Simon Xiao > > 1. Introduce netif-msg to netvsc to control debug logging output > and keep msg_enable in netvsc_device_context so that it is > kept persistently. > 2. Only call dump_rndis_message() when NETIF_MSG_RX_ERR or abo

[PATCH net-next,v2,1/1] hv_netvsc: introduce netif-msg into netvsc module

2015-04-24 Thread sixiao
From: Simon Xiao 1. Introduce netif-msg to netvsc to control debug logging output and keep msg_enable in netvsc_device_context so that it is kept persistently. 2. Only call dump_rndis_message() when NETIF_MSG_RX_ERR or above is specified in netvsc module debug param. In non-debug mode, in current