Re: [PATCH net-next] bonding: correct rr balancing during link failure

2020-12-15 Thread Lars Everbrand
On Tue, Dec 08, 2020 at 01:46:09PM -0800, Jay Vosburgh wrote: > > Jakub Kicinski wrote: > > >On Wed, 02 Dec 2020 20:55:57 + Lars Everbrand wrote: > Are these bandwidth numbers from observation of the actual > behavior? I'm not sure the real system would behave this way; my >

Re: [PATCH net-next] bonding: correct rr balancing during link failure

2020-12-15 Thread Lars Everbrand
On Sat, Dec 05, 2020 at 11:45:13AM -0800, Jakub Kicinski wrote: > Thanks for the patch! Kind words for my first attempt at this. Sorry for answering a bit late, proton-bridge is not my best friend lately. > > Looking at the code in question it feels a little like we're breaking > abstractions if

Re: [PATCH net-next] bonding: correct rr balancing during link failure

2020-12-08 Thread Jay Vosburgh
Jakub Kicinski wrote: >On Wed, 02 Dec 2020 20:55:57 + Lars Everbrand wrote: >> This patch updates the sending algorithm for roundrobin to avoid >> over-subscribing interface(s) when one or more interfaces in the bond is >> not able to send packets. This happened when order was not random and

Re: [PATCH net-next] bonding: correct rr balancing during link failure

2020-12-05 Thread Jakub Kicinski
On Wed, 02 Dec 2020 20:55:57 + Lars Everbrand wrote: > This patch updates the sending algorithm for roundrobin to avoid > over-subscribing interface(s) when one or more interfaces in the bond is > not able to send packets. This happened when order was not random and > more than 2 interfaces

[PATCH net-next] bonding: correct rr balancing during link failure

2020-12-02 Thread Lars Everbrand
This patch updates the sending algorithm for roundrobin to avoid over-subscribing interface(s) when one or more interfaces in the bond is not able to send packets. This happened when order was not random and more than 2 interfaces were used. Previously the algorithm would find the next available