Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 23:31:48 +0100 Horatiu Vultur wrote: > > The existing structs are only present in net-next as well, so if you > > don't mind Horatiu it'd be good to follow up and remove the unused ones > > and move the ones (if any) which are only used by the kernel but not by > > the user

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Horatiu Vultur
The 11/23/2020 14:05, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 23 Nov 2020 16:25:53 +0200 Nikolay Aleksandrov wrote: > > >>> @@ -156,4 +157,10 @@ struct br_mrp_in_link_hdr { > > >>> __be16 interval; > >

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Jakub Kicinski
On Mon, 23 Nov 2020 16:25:53 +0200 Nikolay Aleksandrov wrote: > >>> @@ -156,4 +157,10 @@ struct br_mrp_in_link_hdr { > >>> __be16 interval; > >>> }; > >>> > >>> +struct br_mrp_in_link_status_hdr { > >>> + __u8 sa[ETH_ALEN]; > >>> + __be16 port_role; > >>> + __be16 id; > >>> +};

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Nikolay Aleksandrov
On 23/11/2020 14:31, Horatiu Vultur wrote: > The 11/23/2020 14:13, Nikolay Aleksandrov wrote: >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the >> content is safe >> >> On 23/11/2020 13:14, Horatiu Vultur wrote: >>> Extend MRP to support LC mode(link check) for the

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Horatiu Vultur
The 11/23/2020 14:13, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On 23/11/2020 13:14, Horatiu Vultur wrote: > > Extend MRP to support LC mode(link check) for the interconnect port. > > This applies only to the

Re: [PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Nikolay Aleksandrov
On 23/11/2020 13:14, Horatiu Vultur wrote: > Extend MRP to support LC mode(link check) for the interconnect port. > This applies only to the interconnect ring. > > Opposite to RC mode(ring check) the LC mode is using CFM frames to > detect when the link goes up or down and based on that the

[PATCH net-next] bridge: mrp: Implement LC mode for MRP

2020-11-23 Thread Horatiu Vultur
Extend MRP to support LC mode(link check) for the interconnect port. This applies only to the interconnect ring. Opposite to RC mode(ring check) the LC mode is using CFM frames to detect when the link goes up or down and based on that the userspace will need to react. One advantage of the LC mode