Re: [PATCH net-next] ethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create

2019-02-08 Thread David Miller
From: Nathan Chancellor Date: Thu, 7 Feb 2019 21:46:53 -0700 > net/core/ethtool.c:3023:19: warning: address of array > 'ext_m_spec->h_dest' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (ext_m_spec->h_dest) { > ~~ ^~ > >

Re: [PATCH net-next] ethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create

2019-02-08 Thread Pablo Neira Ayuso
On Thu, Feb 07, 2019 at 09:46:53PM -0700, Nathan Chancellor wrote: > net/core/ethtool.c:3023:19: warning: address of array > 'ext_m_spec->h_dest' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (ext_m_spec->h_dest) { > ~~ ^~ > >

[PATCH net-next] ethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create

2019-02-07 Thread Nathan Chancellor
net/core/ethtool.c:3023:19: warning: address of array 'ext_m_spec->h_dest' will always evaluate to 'true' [-Wpointer-bool-conversion] if (ext_m_spec->h_dest) { ~~ ^~ h_dest is an array, it can't be null so remove this check. Fixes: eca4205f9ec3