Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions

2014-10-06 Thread josh
On Mon, Oct 06, 2014 at 03:04:24PM -0700, Joe Perches wrote: > On Mon, 2014-10-06 at 17:56 -0400, David Miller wrote: > > From: Joe Perches > > Date: Mon, 06 Oct 2014 14:51:38 -0700 > > > > > Reduce noise when compiling W=1. > [] > > BTW, this patch reminds me that if people think there are > > s

Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions

2014-10-06 Thread David Miller
From: Joe Perches Date: Mon, 06 Oct 2014 15:04:24 -0700 > On Mon, 2014-10-06 at 17:56 -0400, David Miller wrote: >> From: Joe Perches >> Date: Mon, 06 Oct 2014 14:51:38 -0700 >> >> > Reduce noise when compiling W=1. > [] >> BTW, this patch reminds me that if people think there are >> subdirecto

Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions

2014-10-06 Thread Cong Wang
On Mon, Oct 6, 2014 at 2:51 PM, Joe Perches wrote: > John, can you please verify that these gen_stats accesses > are unnecessary? I believe the compiler can elide them in > any case, but I'm not sure what you intended here. > > net/core/dev.c | 4 ++-- > net/core/gen_stats.c | 4 > ne

Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions

2014-10-06 Thread Joe Perches
On Mon, 2014-10-06 at 17:56 -0400, David Miller wrote: > From: Joe Perches > Date: Mon, 06 Oct 2014 14:51:38 -0700 > > > Reduce noise when compiling W=1. [] > BTW, this patch reminds me that if people think there are > subdirectories where we can turn on things like -Werror in the > networking I

Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions

2014-10-06 Thread Eric Dumazet
On Mon, 2014-10-06 at 14:51 -0700, Joe Perches wrote: > Reduce noise when compiling W=1. > > All the variables are unused. > The functions are not called outside of the file so static > is preferred. > > Signed-off-by: Joe Perches > --- > > John, can you please verify that these gen_stats acces

Re: [PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions

2014-10-06 Thread David Miller
From: Joe Perches Date: Mon, 06 Oct 2014 14:51:38 -0700 > Reduce noise when compiling W=1. > > All the variables are unused. > The functions are not called outside of the file so static > is preferred. > > Signed-off-by: Joe Perches > --- > > John, can you please verify that these gen_stats a

[PATCH net-next] net: core: Quiet W=1 warnings for unused vars and static functions

2014-10-06 Thread Joe Perches
Reduce noise when compiling W=1. All the variables are unused. The functions are not called outside of the file so static is preferred. Signed-off-by: Joe Perches --- John, can you please verify that these gen_stats accesses are unnecessary? I believe the compiler can elide them in any case, b