Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-25 Thread Oleksandr Mazur
Thu, Jan 21, 2021 at 06:36:05PM CET, k...@kernel.org wrote: >On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: >> On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: >> > Add new trap action HARD_DROP, which can be used by the >> > drivers to register traps, where it's impossible

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-25 Thread Ido Schimmel
On Mon, Jan 25, 2021 at 03:56:14PM +0100, Jiri Pirko wrote: > Mon, Jan 25, 2021 at 01:24:27PM CET, oleksandr.ma...@plvision.eu wrote: > >Thu, Jan 21, 2021 at 06:36:05PM CET, k...@kernel.org wrote: > >>On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: > >>> On Thu, Jan 21, 2021 at 01:29:37PM

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-25 Thread Jiri Pirko
Mon, Jan 25, 2021 at 01:24:27PM CET, oleksandr.ma...@plvision.eu wrote: >Thu, Jan 21, 2021 at 06:36:05PM CET, k...@kernel.org wrote: >>On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: >>> On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: >>> > Add new trap action HARD_DROP,

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-25 Thread Jiri Pirko
Thu, Jan 21, 2021 at 06:36:05PM CET, k...@kernel.org wrote: >On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: >> On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: >> > Add new trap action HARD_DROP, which can be used by the >> > drivers to register traps, where it's impossible

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-24 Thread Ido Schimmel
On Sat, Jan 23, 2021 at 12:14:39PM -0800, Jakub Kicinski wrote: > On Sat, 23 Jan 2021 18:03:48 +0200 Ido Schimmel wrote: > > [DEVLINK_ATTR_STATS_RX_DROPPED] > > nit: maybe discarded? dropped sounds like may have been due to an > overflow or something Well, it's an existing attribute which is

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-23 Thread Jakub Kicinski
On Sat, 23 Jan 2021 18:03:48 +0200 Ido Schimmel wrote: > [DEVLINK_ATTR_STATS_RX_DROPPED] nit: maybe discarded? dropped sounds like may have been due to an overflow or something

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-23 Thread Ido Schimmel
On Fri, Jan 22, 2021 at 08:36:01AM +, Oleksandr Mazur wrote: > On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: > > On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: > > > Add new trap action HARD_DROP, which can be used by the > > > drivers to register traps, where it's

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 08:36:01 + Oleksandr Mazur wrote: > On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: > > On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: > > > Add new trap action HARD_DROP, which can be used by the > > > drivers to register traps, where it's

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-22 Thread Oleksandr Mazur
On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: > On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: > > Add new trap action HARD_DROP, which can be used by the > > drivers to register traps, where it's impossible to get > > packet reported to the devlink subsystem by the

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-22 Thread Oleksandr Mazur
From: Ido Schimmel Sent: Thursday, January 21, 2021 2:21 PM To: Oleksandr Mazur Cc: net...@vger.kernel.org ; j...@nvidia.com ; da...@davemloft.net ; linux-kernel@vger.kernel.org ; k...@kernel.org Subject: Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP   On Thu, Jan

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-21 Thread Jakub Kicinski
On Thu, 21 Jan 2021 14:21:52 +0200 Ido Schimmel wrote: > On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: > > Add new trap action HARD_DROP, which can be used by the > > drivers to register traps, where it's impossible to get > > packet reported to the devlink subsystem by the

Re: [PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-21 Thread Ido Schimmel
On Thu, Jan 21, 2021 at 01:29:37PM +0200, Oleksandr Mazur wrote: > Add new trap action HARD_DROP, which can be used by the > drivers to register traps, where it's impossible to get > packet reported to the devlink subsystem by the device > driver, because it's impossible to retrieve dropped packet

[PATCH net-next] net: core: devlink: add new trap action HARD_DROP

2021-01-21 Thread Oleksandr Mazur
Add new trap action HARD_DROP, which can be used by the drivers to register traps, where it's impossible to get packet reported to the devlink subsystem by the device driver, because it's impossible to retrieve dropped packet from the device itself. In order to use this action, driver must also