From: Menglong Dong <dong.mengl...@zte.com.cn>

For now, there is only one element in netns_core_table, and it is inited
directly in sysctl_core_net_init. To make it more flexible, we can init
every element at once, just like what ipv4_sysctl_init_net() did.

Signed-off-by: Menglong Dong <dong.mengl...@zte.com.cn>
---
 net/core/sysctl_net_core.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
index d86d8d11cfe4..966d976dee84 100644
--- a/net/core/sysctl_net_core.c
+++ b/net/core/sysctl_net_core.c
@@ -606,15 +606,19 @@ static __net_init int sysctl_core_net_init(struct net 
*net)
 
        tbl = netns_core_table;
        if (!net_eq(net, &init_net)) {
+               int i;
+
                tbl = kmemdup(tbl, sizeof(netns_core_table), GFP_KERNEL);
                if (tbl == NULL)
                        goto err_dup;
 
-               tbl[0].data = &net->core.sysctl_somaxconn;
+               /* Update the variables to point into the current struct net */
+               for (i = 0; i < ARRAY_SIZE(netns_core_table) - 1; i++) {
+                       tbl[i].data += (void *)net - (void *)&init_net;
 
-               /* Don't export any sysctls to unprivileged users */
-               if (net->user_ns != &init_user_ns) {
-                       tbl[0].procname = NULL;
+                       /* Don't export any sysctls to unprivileged users */
+                       if (net->user_ns != &init_user_ns)
+                               tbl[i].procname = NULL;
                }
        }
 
-- 
2.30.0

Reply via email to